search

Ranchero-Software / NetNewsWire

RSS reader for macOS and iOS.
https://netnewswire.com/
MIT License
8.21k stars 520 forks source link

Items that link to PDFs fail to load in reader view #1616

Open blackketter opened 4 years ago

blackketter commented 4 years ago

If an item points to a PDF file rather than a web page it fails to load in reader view. It wold be great if a pdf is detected it is just loaded and displayed rather than failing.

This is related to #1542, which prevents PDF items from being available at all if auto reader view is on.

vincode-io commented 4 years ago

Do you have a feed you can share that has this behavior? I've never seen a blog that has its posts displayed as PDF's before.

blackketter commented 4 years ago

Sure. The Hacker News feed does this pretty regularly:

http://news.ycombinator.com/rss

There's an item in there from today:

<item>
<title>Patch Critical Cryptographic Vulnerability in Microsoft Windows [pdf]</title>
<link>https://media.defense.gov/2020/Jan/14/2002234275/-1/-1/0/CSA-WINDOWS-10-CRYPT-LIB-20190114.PDF</link>
<pubDate>Tue, 14 Jan 2020 18:16:39 +0000</pubDate>
<comments>https://news.ycombinator.com/item?id=22047573</comments>
<description>
<![CDATA[<a href="https://news.ycombinator.com/item?id=22047573">Comments</a>]]>
</description>
</item>
blackketter commented 4 years ago

I see in the new release that the PDFs fail to load but now show the original RSS data. That's good! You can tap on the title to open the PDF in the web view. Also good! There's a cosmetic bug where on the first visit to the page the reader view button continues to animate after the failure. (It stops animating after viewing the PDF and returning).