Closed brentsimmons closed 4 years ago
I was experiencing crashes matching the above stack trace but release 5.1.2 doesn't seem to have fixed it, in that reading the same feed crashes with a slightly different stack now:
Crashing on exception: NSRLEArray objectAtIndex:effectiveRange:: Out of bounds
Application Specific Backtrace 1:
0 CoreFoundation 0x00007fff35a5fb57 __exceptionPreprocess + 250
1 libobjc.A.dylib 0x00007fff6e7125bf objc_exception_throw + 48
2 Foundation 0x00007fff3808ac36 blockForLocation + 0
3 Foundation 0x00007fff3808b815 -[NSConcreteAttributedString attribute:atIndex:effectiveRange:] + 58
4 NetNewsWire 0x000000010a5b64d5 NetNewsWire + 595157
5 NetNewsWire 0x000000010a61ac6d NetNewsWire + 1006701
6 NetNewsWire 0x000000010a61b9af NetNewsWire + 1010095
7 NetNewsWire 0x000000010a646035 NetNewsWire + 1183797
8 NetNewsWire 0x000000010a647cf3 NetNewsWire + 1191155
9 NetNewsWire 0x000000010a6461e8 NetNewsWire + 1184232
10 AppKit 0x00007fff32c8d1d1 -[NSView setFrameSize:] + 2045
11 AppKit 0x00007fff32d1a490 -[NSTableCellView setFrameSize:] + 199
12 NetNewsWire 0x000000010a6457e8 NetNewsWire + 1181672
13 AppKit 0x00007fff32c9f03e -[NSView setFrame:] + 423
14 AppKit 0x00007fff32d171ee -[NSTableRowData _addViewToRowView:atColumn:row:] + 461
...
Also, on retrying it doesn't always crash immediately but may fail to update/redraw the article list instead. The one feed URL that causes this crash (sometimes, depending on current content presumably) is https://moringmark.tumblr.com/rss
Reopened and moved it to 5.1.3. The crash may be slightly different, but it appears to be in the same area.
(I’ll symbolicate it to be sure.)
Also, on retrying it doesn't always crash immediately but may fail to update/redraw the article list instead. The one feed URL that causes this crash (sometimes, depending on current content presumably) is
https://moringmark.tumblr.com/rss
Thanks, having a feed that causes this issue will be really helpful. (I didn’t have any feeds that triggered this so I was just going by the line number in the symbolication before.)
To be precise: not every article in that feed crashes NetNewsWire, but that's the only feed that causes this crash, and when it does, it almost always causes consistent crashes on trying again (until I manage to mark all the articles read so they don't get listed again, or at least not as unread).
Reopened and moved it to 5.1.3. The crash may be slightly different, but it appears to be in the same area.
(I’ll symbolicate it to be sure.)
Do you have that symbolication I can check out?
I wonder if it's choking on the empty titles (kind of grasping at straws, though).
Also, @kpreid, which OS version are you on?
Looks like for at least one article that has a title, it's not being displayed at all. 🤔 Edit: Wait, no, that's the feed's title.
Also, @kpreid, which OS version are you on?
System Version: macOS 10.15.7 (19H2)
The lack of titles does seem like a plausible factor. I have lots of other Tumblr feeds but skimming them, all of them seem to have snippets or “Photo” for titles. I don't know why this one doesn't.
Here’s a symbolicated version:
Application Specific Information:
Crashing on exception: NSRLEArray objectAtIndex:effectiveRange:: Out of bounds
Application Specific Backtrace 1:
0 CoreFoundation 0x00007fff35a5fb57 __exceptionPreprocess + 250
1 libobjc.A.dylib 0x00007fff6e7125bf objc_exception_throw + 48
2 Foundation 0x00007fff3808ac36 blockForLocation + 0
3 Foundation 0x00007fff3808b815 -[NSConcreteAttributedString attribute:atIndex:effectiveRange:] + 58
4 NetNewsWire 0x00000001051554d5 specialized static MultilineTextFieldSizer.size(for:numberOfLines:width:) (in NetNewsWire) (MultilineTextFieldSizer.swift:58)
5 NetNewsWire 0x00000001051b9c6d specialized static TimelineCellLayout.rectForTitle(_:_:_:) (in NetNewsWire) (TimelineCellLayout.swift:119)
6 NetNewsWire 0x00000001051ba9af specialized TimelineCellLayout.init(width:height:cellData:appearance:hasIcon:) (in NetNewsWire) (TimelineCellLayout.swift:58)
7 NetNewsWire 0x00000001051e5035 TimelineTableCellView.updatedLayoutRects() (in NetNewsWire) (<compiler-generated>:0)
8 NetNewsWire 0x00000001051e6cf3 specialized TimelineTableCellView.resizeSubviews(withOldSize:) (in NetNewsWire) (TimelineTableCellView.swift:117)
9 NetNewsWire 0x00000001051e51e8 @objc TimelineTableCellView.resizeSubviews(withOldSize:) (in NetNewsWire) (<compiler-generated>:0)
10 AppKit 0x00007fff32c8d1d1 -[NSView setFrameSize:] + 2045
11 AppKit 0x00007fff32d1a490 -[NSTableCellView setFrameSize:] + 199
12 NetNewsWire 0x00000001051e47e8 NetNewsWire + 1181672
13 AppKit 0x00007fff32c9f03e -[NSView setFrame:] + 423
14 AppKit 0x00007fff32d171ee -[NSTableRowData _addViewToRowView:atColumn:row:] + 461