Unable to add feed alert wording

[stuartbreckenridge]

We have two very different alert titles and messages when NetNewsWire cannot add feeds when they are not found.

In this example, the website was bbc.com/news:

Mac:

• Title: Feed not found
• Informative Text: Can't add a feed because no feed was found.

iOS:

• Title: Error
• Informative Text: The feed couldn't be found and can't be added.

I'd propose bringing consistency to them:

• Title: Unable to Add Feed
• Informative Text: No feed was found at that address.

[brentsimmons]

I like the title “Unable to Add Feed.”

Error text should almost always be of the form “Can’t do x because y.” So the text should remain:

“Can’t add a feed because no feed was found.”

[stuartbreckenridge]

Can I fix this in the internationalization PR?

[brentsimmons]

Yes — good thinking.

[brentsimmons]

(Closed by accident. Oops!)

[stuartbreckenridge]

This is fixed in ceb925d.

Note that this commit localises AccountError in the Account package, and both iOS and macOS now use those strings. This means that the iOS / macOS apps don't need to have independent copies of those strings in their respective strings files.

[stuartbreckenridge]