Ranchero-Software / NetNewsWire

RSS reader for macOS and iOS.
https://netnewswire.com/
MIT License
8.42k stars 534 forks source link

Feedbin: Recently Read Entries #699

Open pyrmont opened 5 years ago

pyrmont commented 5 years ago

This is definitely not something I imagine everyone needs/wants but I'm a big user of Feedbin's 'Recently Read' list and would love for NetNewsWire to support it. This is something that requires an additional API call.

pyrmont commented 5 years ago

Perhaps this is where the logic would need to go:

https://github.com/brentsimmons/NetNewsWire/blob/ea8d794b61d0fed1fcd22be77bbf575307a14244/Frameworks/Account/Feedbin/FeedbinAccountDelegate.swift#L1109-L1141

pyrmont commented 5 years ago

To be clear: what I'm interested in is merely NetNewsWire merely marking read items as 'Recently Read'. Retrieving the list and displaying that is something that would be nice to have but is not anything I think anyone would worry about not having.

pyrmont commented 5 years ago

I discussed this in the Slack #work channel with @vincode-io.

I proposed as a naïve solution making a call to Feedbin's Recently Read API whenever a call was made to mark an item as read. Maurice pointed out that this would mean that items would be marked as 'recently read' when a user marked a batch of items as read.

This is not the behaviour that users see when using the Feedbin web interface. There, an item must be open for 10 seconds before being marked as 'recently read'. NNW might want to take a similar 'open for 10 seconds' approach. This would require more extensive changes to the codebase.

For my needs, the naïve solution is sufficient and so I plan on maintaining a separate branch with that functionality for the time being.

pyrmont commented 5 years ago

Naïve solution: https://github.com/pyrmont/NetNewsWire/commit/c1fe88713e44058eaaa12b5d3d826bfc141a896f

brentsimmons commented 5 years ago

This is a feature NNW itself should also have, and it should work with Feedbin. This requires a bunch of thought and design before implementation. Thanks for bringing up the issue!