Collection copying only when changed

[freelon]

For #114

Currently the test TestCollections.testRecordBuilderOptionsCopied fails, since I had to change the signature of the __list() shim methods. The problem is, that the code as on master generates setters for collections with different signatures: If addSingleItemCollectionBuilders == true: someList(Collection<? extends ListItem> someList), but otherwise the someList parameter is of type List<...>. I didn't want to change that behavior together with the other ticket, though (see #117 ).

[Randgalt]

Currently the test TestCollections.testRecordBuilderOptionsCopied fails, since I had to change the signature of the __list() shim methods. The problem is, that the code as on master generates setters for collections with different signatures:

Instead of making a backward incompatible change can't we add a 2 __list shims? One for List and one for Collection?

[freelon]

Instead of making a backward incompatible change can't we add a 2 __list shims? One for List and one for Collection?

Of course, but why keep __list(List<X> o)? It's more restrictive and does the same as __list(Collection ...). Also, it's a private method, so I'd think backwards compatibility is not much of an issue.

[Randgalt]

Currently the test TestCollections.testRecordBuilderOptionsCopied fails, since I had to change the signature of the __list() shim methods. The problem is, that the code as on master generates setters for collections with different signatures:

Instead of making a backward incompatible change can't we add a 2 __list shims? One for List and one for Collection?

True - but in that case the test can be fixed here right?

[freelon]

Yes, I already did that. I just didn't want to lead with changing tests ;)

[freelon]

Is there anything more to do on this or can it be merged? From my POV all the discussed points are solved.

[Randgalt]

I apologize - I got bogged down with work. I'll get to this soon (hopefully this week)

[Randgalt]

LGTM - thank you very much