search

Randgalt / record-builder

Record builder generator for Java records
Apache License 2.0
723 stars 51 forks source link

Introduced useUnmodifiableCollections option #154

Closed pawellabaj closed 1 year ago

pawellabaj commented 1 year ago

Introduced useUnmodifiableCollections option. Related to Randgalt/record-builder/#153

Randgalt commented 1 year ago

@pawellabaj tests are breaking which suggests to me this should be behind an option.

pawellabaj commented 1 year ago

@Randgalt option sounds OK

How it should look like?

Randgalt commented 1 year ago

You would add an option here: https://github.com/Randgalt/record-builder/blob/master/record-builder-core/src/main/java/io/soabase/recordbuilder/core/RecordBuilder.java#L68 - there are many examples in the code

pawellabaj commented 1 year ago

@Randgalt , what a timing? :-)

Please, see at my proposed option and latest changes in a code

Randgalt commented 1 year ago

I'll get to this this week. @pawellabaj can you merge the two commits please?

pawellabaj commented 1 year ago

can you merge the two commits please?

@Randgalt , I squashed commits. I assumed you meant that, didn't you?

Randgalt commented 1 year ago

Looks good. Please run mvn clean verify locally. The auto-formatter will make a few changes. Commit and push those changes before we merge this.

pawellabaj commented 1 year ago

Looks good. Please run mvn clean verify locally. The auto-formatter will make a few changes. Commit and push those changes before we merge this.

@Randgalt , done

Randgalt commented 1 year ago

Thanks for the PR

pawellabaj commented 1 year ago

Great, waiting for the new release

Randgalt commented 1 year ago

done