search

Randgalt / record-builder

Record builder generator for Java records
Apache License 2.0
756 stars 55 forks source link

Add support for Java Platform Module System #28

Closed mgorniew closed 3 years ago

mgorniew commented 3 years ago

It would be good to add support for JPMS. With this change it will be possible to use record-builder in module-info.java:

module test.module {
    requires static io.soabase.recordbuilder.core;
    requires static java.compiler;
}
Randgalt commented 3 years ago

Thank you for this. I tried to add minimal JPMS support before and it ended up causing compiler problems. Do you have a link to a doc or something that shows this is the acceptable minimum for JPMS? Also, I'll do some local testing with this.

Randgalt commented 3 years ago

I tried with Maven both with the standard classpath and the module path. It seems to work correctly. Thanks for the PR.