search

RandomComputerUser / FancyLighting-Terraria

Fancy Lighting Mod for Terraria
MIT License
7 stars 1 forks source link

Smooth lighting causes massive flickering with other mods in Aether. #4

Open awdwyn opened 10 months ago

awdwyn commented 10 months ago

Using primarily Calamity and Remnants, though with more mods installed, I get a bunch of flickering as soon as I enter the Aether.

Video showing the issue: https://youtu.be/tPWj4myDEHo

List of enabled mods: [ "AlchemistNPCLite", "androLib", "Bags", "BankButtons", "BetterBlending", "BossChecklist", "BossCursor", "CalamityAmmo", "CalamityFlamethrowers", "CalamityMod", "CalamityModMusic", "CalamityRarities", "CalamityShoes", "calamityzeith", "CalValEX", "CampingMod", "CatalystMod", "CellphonePylon", "Census", "ColoredDamageTypes", "CraftableAccessories", "DialogueTweak", "DisableCorruptionSpread", "FancyLighting", "GhostRespawn", "GravityDontFlipScreen", "HookStatsAndWingStats", "KokoLib", "LockBoxesPlus", "LookMod", "LootBeams", "LureBaitDisplay", "MagicStorage", "MeleeEffects", "MoreAccessories", "NoFishingQuests", "NoPylonRestrictions", "PortableWormhole", "PotionCharms", "RecipeBrowser", "RecipeBrowserToMagicStorage", "Remnants", "SerousCommonLib", "ShoeSlot", "ShopExpander", "ShopQuotesMod", "ShorterRespawn", "SmarterCursor", "SquintlysFurnitureMod", "StructureHelper", "SummonsUI", "Terrarchitect", "TrueTooltips", "VacuumOreBag", "WeaponDisplay", "WeaponEnchantments", "WheresMyItems", "WingSlotExtra", "WMITF", "WombatQOL" ]

Tyfyter commented 1 month ago

This appears to only trigger with "Enable Smooth Lighting" and "Use Enhanced Shaders and Colors" enabled, and "Light Map Render Mode" set to "Bicubic with Overbright", which is exactly the feature set that enables gamma correction; Despite this, as far as I can tell it never affects camera mode, and it's almost certainly an issue with setting something into a different state than it was in before given it's unique to shimmer drawing and flashes the shimmer texture, considering this I believe that it is an issue within the drawing methods in FancyLightingMod.cs, likely not setting the render target back to what it should be somewhere.