RandomEngy / VidCoder

A Blu-ray, DVD and video file transcoder for Windows.
http://vidcoder.net
GNU General Public License v2.0
701 stars 42 forks source link

Post-encoding: Recycle: Immediately after encode completes #1130

Open Neipas09 opened 1 year ago

Neipas09 commented 1 year ago

Problem Description

The source file does NOT get sent to the recycle bin after it's encoded. Doesn't matter if I encode 1 file or multiple.

These are my settings for Post-encoding. image

What version of VidCoder are you running?

9.3 Beta

Encode Log

VC [11:50:56] VidCoder 9.3 Beta
VC [11:50:56] Starting job 1/1
VC [11:50:56]   Source path: C:\[TORRENTS]\Complete\[SubsPlease] Jigokuraku - 01 (720p) [3E45EA7B].mkv
VC [11:50:56]   Destination path: C:\Users\SourMilkNPennies\Desktop\ReEncoded Movies\[SubsPlease] Jigokuraku - 01 (720p) [3E45EA7B].mp4
VC [11:50:56]   Title: 1
VC [11:50:56]   Range: All
VC [11:50:56]   Preset: Anime 720p
VC [11:50:56] Worker ready: Pipe 'VidCoderWorker.ca1dca79-0656-4633-8883-b54098a0c1fa' is open
VC [11:50:56] Connecting to process 15296 on pipe VidCoderWorker.ca1dca79-0656-4633-8883-b54098a0c1fa
HB [11:50:57] CPU: 12th Gen Intel(R) Core(TM) i7-12700K
[11:50:57]  - Intel microarchitecture Alder Lake performance hybrid architecture
[11:50:57]  - logical processor count: 20
[11:50:57] Intel Quick Sync Video support: no
[11:50:57] hb_scan: path=C:\[TORRENTS]\Complete\[SubsPlease] Jigokuraku - 01 (720p) [3E45EA7B].mkv, title_index=1
udfread ERROR: ECMA 167 Volume Recognition failed
src/libbluray/disc/disc.c:333: failed opening UDF image C:\[TORRENTS]\Complete\[SubsPlease] Jigokuraku - 01 (720p) [3E45EA7B].mkv
src/libbluray/disc/disc.c:437: error opening file BDMV\index.bdmv
src/libbluray/disc/disc.c:437: error opening file BDMV\BACKUP\index.bdmv
[11:50:57] bd: not a bd - trying as a stream/file instead
libdvdread: DVDOpenFileUDF:UDFFindFile /VIDEO_TS/VIDEO_TS.IFO failed
libdvdnav: vm: vm: failed to read VIDEO_TS.IFO
[11:50:57] dvd: not a dvd - trying as a stream/file instead
Input #0, matroska,webm, from 'C:\[TORRENTS]\Complete\[SubsPlease] Jigokuraku - 01 (720p) [3E45EA7B].mkv':
  Metadata:
    encoder         : no_variable_data
    creation_time   : 1970-01-01T00:00:00.000000Z
  Duration: 00:24:25.11, start: 0.000000, bitrate: 4148 kb/s
  Stream #0:0: Video: h264 (High), yuv420p(tv, bt709, progressive), 1280x720 [SAR 1:1 DAR 16:9], 23.98 fps, 23.98 tbr, 1k tbn (default)
    Metadata:
      BPS-eng         : 3982708
      DURATION-eng    : 00:24:25.049000000
      NUMBER_OF_FRAMES-eng: 35126
      NUMBER_OF_BYTES-eng: 729357813
      _STATISTICS_WRITING_APP-eng: no_variable_data
      _STATISTICS_WRITING_DATE_UTC-eng: 1970-01-01 00:00:00
      _STATISTICS_TAGS-eng: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
  Stream #0:1(jpn): Audio: aac (LC), 44100 Hz, stereo, fltp (default)
    Metadata:
      BPS-eng         : 128000
      DURATION-eng    : 00:24:25.109000000
      NUMBER_OF_FRAMES-eng: 63097
      NUMBER_OF_BYTES-eng: 23441752
      _STATISTICS_WRITING_APP-eng: no_variable_data
      _STATISTICS_WRITING_DATE_UTC-eng: 1970-01-01 00:00:00
      _STATISTICS_TAGS-eng: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
  Stream #0:2(eng): Subtitle: ass (default)
    Metadata:
      title           : English subs
      BPS-eng         : 114
      DURATION-eng    : 00:22:24.100000000
      NUMBER_OF_FRAMES-eng: 301
      NUMBER_OF_BYTES-eng: 19300
      _STATISTICS_WRITING_APP-eng: no_variable_data
      _STATISTICS_WRITING_DATE_UTC-eng: 1970-01-01 00:00:00
      _STATISTICS_TAGS-eng: BPS DURATION NUMBER_OF_FRAMES NUMBER_OF_BYTES
  Stream #0:3: Attachment: ttf
    Metadata:
      filename        : Roboto-Medium.ttf
      mimetype        : application/x-truetype-font
  Stream #0:4: Attachment: ttf
    Metadata:
      filename        : Roboto-MediumItalic.ttf
      mimetype        : application/x-truetype-font
  Stream #0:5: Attachment: ttf
    Metadata:
      filename        : arial.ttf
      mimetype        : application/x-truetype-font
  Stream #0:6: Attachment: ttf
    Metadata:
      filename        : arialbd.ttf
      mimetype        : application/x-truetype-font
  Stream #0:7: Attachment: ttf
    Metadata:
      filename        : comic.ttf
      mimetype        : application/x-truetype-font
  Stream #0:8: Attachment: ttf
    Metadata:
      filename        : comicbd.ttf
      mimetype        : application/x-truetype-font
  Stream #0:9: Attachment: ttf
    Metadata:
      filename        : times.ttf
      mimetype        : application/x-truetype-font
  Stream #0:10: Attachment: ttf
    Metadata:
      filename        : timesbd.ttf
      mimetype        : application/x-truetype-font
  Stream #0:11: Attachment: ttf
    Metadata:
      filename        : trebuc.ttf
      mimetype        : application/x-truetype-font
  Stream #0:12: Attachment: ttf
    Metadata:
      filename        : trebucbd.ttf
      mimetype        : application/x-truetype-font
  Stream #0:13: Attachment: ttf
    Metadata:
      filename        : verdana.ttf
      mimetype        : application/x-truetype-font
  Stream #0:14: Attachment: ttf
    Metadata:
      filename        : verdanab.ttf
      mimetype        : application/x-truetype-font
  Stream #0:15: Attachment: ttf
    Metadata:
      filename        : CONSOLA.TTF
      mimetype        : application/x-truetype-font
  Stream #0:16: Attachment: ttf
    Metadata:
      filename        : CONSOLAB.TTF
      mimetype        : application/x-truetype-font
[11:50:57] scan: decoding previews for title 1
[11:50:57] scan: audio 0x1: aac, rate=44100Hz, bitrate=1 ??? (AAC LC) (2.0 ch)
HB [11:50:57] scan: 60 previews, 1280x720, 23.976 fps, autocrop = 0/0/0/0, aspect 16:9, PAR 1:1, color profile: 1-1-1, chroma location: left
[11:50:57] scan: supported video decoders: avcodec nvdec
[11:50:58] libhb: scan thread found 1 valid title(s)
HB [11:50:58] Starting work at: Sat Apr 01 11:50:58 2023
[11:50:58] 1 job(s) to process
[11:50:58] json job:
{
  "Audio": {
    "AudioList": [
      {
        "Bitrate": 160,
        "DRC": 0,
        "Encoder": "copy",
        "Gain": 0,
        "Mixdown": 4,
        "NormalizeMixLevel": false,
        "Samplerate": 44100,
        "Track": 0,
        "DitherMethod": 0
      }
    ],
    "CopyMask": [
      "copy:aac",
      "copy:ac3",
      "copy:eac3",
      "copy:mp2",
      "copy:flac"
    ],
    "FallbackEncoder": "av_aac"
  },
  "Destination": {
    "ChapterList": [],
    "ChapterMarkers": false,
    "AlignAVStart": true,
    "File": "C:\\Users\\SourMilkNPennies\\Desktop\\ReEncoded Movies\\[SubsPlease] Jigokuraku - 01 (720p) [3E45EA7B].part.mp4",
    "Mp4Options": {
      "IpodAtom": false,
      "Mp4Optimize": false
    },
    "Mux": "av_mp4"
  },
  "Filters": {
    "FilterList": [
      {
        "ID": 7,
        "Settings": {
          "mode": "1"
        }
      },
      {
        "ID": 14,
        "Settings": {
          "crop-bottom": "0",
          "crop-left": "0",
          "crop-right": "0",
          "crop-top": "0",
          "height": "720",
          "width": "1280"
        }
      }
    ]
  },
  "PAR": {
    "Num": 1,
    "Den": 1
  },
  "Metadata": {},
  "SequenceID": 0,
  "Source": {
    "Angle": 1,
    "Range": {
      "Type": "chapter",
      "Start": 1,
      "End": 1
    },
    "Title": 1,
    "Path": "C:\\[TORRENTS]\\Complete\\[SubsPlease] Jigokuraku - 01 (720p) [3E45EA7B].mkv"
  },
  "Subtitle": {
    "Search": {
      "Burn": false,
      "Default": false,
      "Enable": false,
      "Forced": false
    },
    "SubtitleList": [
      {
        "Burn": true,
        "Default": false,
        "Forced": false,
        "ID": 1,
        "Offset": 0,
        "Track": 0,
        "Name": "English subs"
      }
    ]
  },
  "Video": {
    "Encoder": "nvenc_h264",
    "Level": "auto",
    "TwoPass": false,
    "Turbo": false,
    "ColorMatrixCode": 0,
    "Options": "",
    "Preset": "slowest",
    "Profile": "auto",
    "Quality": 26,
    "QSV": {
      "Decode": false
    },
    "HardwareDecode": 0
  }
}
[11:50:58] Starting Task: Encoding Pass
[11:50:58] Skipping crop/scale filter
[11:50:58] [ass] libass API version: 0x1600000
[11:50:58] [ass] libass source: tarball: 0.16.0
[11:50:58] [ass] Shaper: FriBidi 1.0.12 (SIMPLE) HarfBuzz-ng 4.4.1 (COMPLEX)
[11:50:58] [ass] Using font provider directwrite (with GDI)
[11:50:58] Auto Passthru: allowed codecs are AAC, AC3, E-AC3, MP2, FLAC
[11:50:58] Auto Passthru: fallback is AAC (avcodec)
[11:50:58] Auto Passthru: using AAC Passthru for track 1
[11:50:58] job configuration:
[11:50:58]  * source
[11:50:58]    + C:\[TORRENTS]\Complete\[SubsPlease] Jigokuraku - 01 (720p) [3E45EA7B].mkv
[11:50:58]    + title 1, chapter(s) 1 to 1
[11:50:58]    + container: matroska,webm
[11:50:58]    + data rate: 4148 kbps
[11:50:58]  * destination
[11:50:58]    + C:\Users\SourMilkNPennies\Desktop\ReEncoded Movies\[SubsPlease] Jigokuraku - 01 (720p) [3E45EA7B].part.mp4
[11:50:58]    + container: MPEG-4 (libavformat)
[11:50:58]      + align initial A/V stream timestamps
[11:50:58]  * video track
[11:50:58]    + decoder: h264 8-bit (yuv420p)
[11:50:58]    + filters
[11:50:58]      + Framerate Shaper (mode=1)
[11:50:58]        + frame rate: 23.976 fps -> constant 23.976 fps
[11:50:58]      + Subtitle renderer ()
[11:50:58]    + Output geometry
[11:50:58]      + storage dimensions: 1280 x 720
[11:50:58]      + pixel aspect ratio: 1 : 1
[11:50:58]      + display dimensions: 1280 x 720
[11:50:58]    + encoder: H.264 (NVEnc)
[11:50:58]      + preset:  slowest
[11:50:58]      + profile: auto
[11:50:58]      + level:   auto
[11:50:58]      + quality: 26.00 (CQ)
[11:50:58]      + color profile: 1-1-1
[11:50:58]      + chroma location: left
[11:50:58]  * subtitle track 1, English [SSA] (track 0, id 0x2, Text) -> Render/Burn-in
[11:50:58]    + name: English subs
[11:50:58]  * audio track 1
[11:50:58]    + decoder: ??? (AAC LC) (2.0 ch) (track 1, id 0x1)
[11:50:58]      + samplerate: 44100 Hz
[11:50:58]    + AAC Passthru
[11:50:58] sync: expecting 35127 video frames
[11:50:58] encavcodecInit: H.264 (Nvidia NVENC)
[11:50:58] encavcodec: encoding at rc=vbr, 26.00
[11:50:58] encavcodec: encoding with stored aspect 1/1
HB [11:50:58] sync: first pts video is 0
[11:50:58] sync: Chapter 1 at frame 1 time 0
[11:50:58] sync: first pts audio 0x1 is 0
HB [11:51:00] sync: first pts subtitle 0x2 is 2718900
[11:51:00] [ass] fontselect: (Roboto Medium, 400, 100) -> Roboto-MediumItalic, 0, Roboto-MediumItalic
HB [11:51:01] [ass] fontselect: (Roboto Medium, 400, 0) -> Roboto-Medium, 0, Roboto-Medium
HB [11:51:12] [ass] fontselect: (Times New Roman, 700, 0) -> TimesNewRomanPS-BoldMT, 0, TimesNewRomanPS-BoldMT
HB [11:51:56] [ass] fontselect: (Georgia, 700, 0) -> Georgia-Bold, 0, Georgia-Bold
HB [11:52:18] reader: done. 1 scr changes
HB [11:52:18] work: average encoding speed for job is 439.299988 fps
HB [11:52:18] vfr: 35126 frames output, 0 dropped and 0 duped for CFR/PFR
[11:52:18] vfr: lost time: 0 (0 frames)
[11:52:18] vfr: gained time: 0 (0 frames) (0 not accounted for)
[11:52:18] aac-decoder done: 63097 frames, 0 decoder errors
[11:52:18] h264-decoder done: 35126 frames, 0 decoder errors
[11:52:18] sync: got 35126 frames, 35127 expected
[11:52:18] sync: framerate min 23.976 fps, max 23.976 fps, avg 23.976 fps
HB [11:52:18] mux: track 0, 35126 frames, 203752706 bytes, 1112.54 kbps, fifo 4096
[11:52:18] mux: track 1, 63097 frames, 23441752 bytes, 128.00 kbps, fifo 8192
[11:52:18] Finished work at: Sat Apr 01 11:52:18 2023
[11:52:18] libhb: work result = 0
VC [11:52:19] Sent 0 source video(s) to Recycle Bin
VC [11:52:19] Job completed (Elapsed Time: 1m 22s)
RandomEngy commented 1 year ago

Check your General log, it breaks down why certain source files weren't deleted. For example:

VC [10:32:31] Prepared candidates for deletion Total: 1 Eligible deletion candidates: 0 Skipped due to file being currently scanned: 1

Neipas09 commented 1 year ago

Well i dunno what to tell ya, but hopefully this helps.

  1. I deleted ALL my log files,
  2. opened vidcoder,
  3. dragged a single video file into it,
  4. let it scan and add the video to queue,
  5. then encoded the video.

Here's all the log files from that 1 single encode, which still did NOT delete the file after encoding completed.

2023-04-01 14.20.51 General.txt 2023-04-01 14.20.57 Scan 【推しの子】 最强阴阳师的异世界转生记 - 13 (B-Global 1920x1080 HEVC AAC MKV) [CFA4328A].txt 2023-04-01 14.21.03 Encode 【推しの子】 最强阴阳师的异世界转生记 - 13 (B-Global 1920x1080 HEVC AAC MKV) [CFA4328A].mp4-succeeded.txt 2023-04-01 14.20.51 Combined.txt

Neipas09 commented 1 year ago

And here's the exact same process as above, only I changed logging to Extended(?) or whatever the highest level is called.

2023-04-01 14.27.16 Combined.txt 2023-04-01 14.27.16 General.txt 2023-04-01 14.27.18 Scan 【推しの子】 最强阴阳师的异世界转生记 - 13 (B-Global 1920x1080 HEVC AAC MKV) [CFA4328A].txt 2023-04-01 14.27.29 Encode 【推しの子】 最强阴阳师的异世界转生记 - 13 (B-Global 1920x1080 HEVC AAC MKV) [CFA4328A]-1.mp4-succeeded.txt 2023-04-01 14.27.29 PipeServer Encode VidCoderWorker.f3bed48f-9648-4c18-b162-2ee8136ce1f0.txt

RandomEngy commented 1 year ago

This is what I found in the logs:

VC [14:22:20] Prepared candidates for deletion Total: 1 Eligible deletion candidates: 0 Skipped due to file being currently scanned: 1

It can't delete the currently loaded video. If you close the video source before you start the queue, it should be sent to the recycle bin after it completes.

Neipas09 commented 1 year ago

If I close the video source? What does that even mean?

RandomEngy commented 1 year ago

Pressing this button: image

The issue is that you can't delete the source file when it's open in the program.

Neipas09 commented 1 year ago

I just tried it with encoding 2 separate video files, and neither of them were deleted. And i dragged them into vidcoder 1 at a time.

So you would think that the first video, that i dragged into vidcoder to be scanned and added to the queue, would no longer be "opened" and just the last one would be. Am i wrong to think that? Or is every file you drag into vidcoder is considered "opened" until i click that X ???

RandomEngy commented 1 year ago

The file that's not loaded should be deleted. What does the General log say about it?

Neipas09 commented 1 year ago

I just tried it again, and it did delete the first file scanned, but not the second. So now you just need to fix it so it deletes the 2nd file after encode completes, regardless if it's "loaded" in vidcoder or not. I have no issues deleting the 2nd file manually while it's "loaded" in vidcoder after the encode.

RandomEngy commented 1 year ago

When the source file is deleted, it invalidates the whole source UI. None of the actions are possible anymore and probably would result in errors. That's the original reason I excluded scanned sources. I think I would need to auto-close the source in order to delete the file. That might be the better option; hopefully people would realize why the video was closed.

Neipas09 commented 1 year ago

The way i see it, if you have "delete after encode completes" selected. Then you don't care why the last video that was scanned was closed out of vidcoder before/after the encode completes as long as the source video is deleted.