RandomEngy / VidCoder

A Blu-ray, DVD and video file transcoder for Windows.
http://vidcoder.net
GNU General Public License v2.0
686 stars 42 forks source link

2.35 beta x64 seems more for bluray than dvd #140

Open 684848484574 opened 7 years ago

684848484574 commented 7 years ago

The new sizing features make it impossible to use width 704 with anamorph and get an 853 width. As is, only 720 can be used. Since 1920 is div by 32, no problem. Therefore, these settings seem geared towards Bluray rather than DVD. Which mod is the anamorph settings using now since there is no option to change? Doesn't seem like 16, which really should be the only option, IMO. Ripping process time has doubled and tripled since installation, even when using older beta version now. What gives? Wasn't this experiment tried a year or so ago with terrible results? Why is padding and rotation so necessary, while anamorphing has been stifled? Isn't CABAC more responsible for some media player's inability to play media, than anamorphing. I claim that 95% of every single professionally mastered/distributed DVD uses anamorphing:

720x480 -> 640x480 720x480 -> 853x480 720x576 -> 768x576 720x576 -> 1024x576

And I have had only good results with changing the 720 width to 704. It used to keep the same anamorph width as 720, changing only the pixel shape slightly. But this release no longer works like that at all. And forget about the dreaded 2.2:1 ratio DVDs that have been yielding garbage rips since the beginning of this (You know, the DVDs with a tiny rectangle in middle of screen and black bars on all four sides. They seem to have AR 1.33:1 until you crop all the black and they become ~2.2:1). There is no fixing these now, nor can I crop the padding from 4:3 and force it back to 4:3. This is why you may want to have two different vidcoders: one for BluRay and one for DVD, if you insist on using this new sizing scheme. By comparison, Blurays are easier because they have fewer AR options. There is no 2.2:1 Bluray!

IMO, 2.26 beta x64 has been my favorite release, but I missed a few between then and now!

Kind regards

RandomEngy commented 7 years ago

It should still work with Anamorphic content just fine, I was testing extensively with letterboxed anamorphic DVD content when I wrote the feature. What happens when you choose Downscale Only and remove the max width and max height? Its aim is to preserve the original picture and tweak the PAR such that the original picture aspect ratio is maintained.

I'm trying to understand if you're saying that either A) The new settings don't maintain the picture aspect ratio OR B) Some content has an incorrect aspect ratio and VidCoder doesn't let you correct for this

If you'd like, you can send me a clip of the DVD you're trying to work with and I can see if VidCoder has an issue handling it. You could create one to share by taking the Normal preset and removing cropping. It would also be helpful to get a copy of the old preset that you liked by running a portable version of the old version and exporting it.

texneus commented 7 years ago

On 2.38 beta (after being absent from Betas for a while) I also have a similar but closely related issue.

What I usually do is to have Vidcoder (or Handbrake) output exactly the same resolution as is input, less cropping, and without anamorphic expansion (PAR = 1:1). The reason I work this way is I find using PAR to be counter intuitive, so I choose to do it on the final video using software that allows me to define the display aspect ratio and/or display resolution explicitly (rather than work in obscure units of PAR). I therefore find your goal to be a good one and would like to see this refined!

However, on in 2.38 beta there does not seem to be a way to accomplish what I am used to doing. I could be persuaded to do differently but currently it appears if I input an anamorphic video there isn't a real intuitive way to know what Vidcoder is going to do with it. In fact, I actually had Vidcoder setup as suggested above (plus "Use Anamorphic" disabled thinking it would give me a 1:1 PAR) for a batch encode and ended up with a whole bunch of videos that were permanently stretched into wide screen that now need to be redone (well, I guess it is 1:1 PAR, just not the effect I thought I would get).

I also don't see how I might intentionally encode a non-anamorphic video as anamorphic (as might be done with when down converting an HD source to standard SD resolutions).

What the OP is likely referring to is more or less the same problem as this is a side effect of cropping video. In NTSC digital video standards (I can't speak for PAL) 16 pixels were originally reserved to ensure timing (horizontal sync) shifts/errors between equipment did not result in lost picture data. The digital frame is encoded as 720 pixels wide, but the actual video within is 704 pixels wide. The correct PAR for a 704x480 video is 10:11 for 4:3 and 40:33 for 16:9. It is certainly arguable whether or not these PARs are appropriate, but for historical reasons I believe this is as intended (and clearly the OP does as well). If they are not then truth be told the error is so minor as to be invisible. In all honesty there is often some error in this (and especially on VHS captures where the bottom 4-6 lines are nothing but distortion), so I might end up with something odd ball, say 712x476, which needs a non-standard PAR to fill the screen to a standard aspect ratio.

Suggestions: (1) Add a sizing mode of "None" to the Sizing Mode dropdown. This allows a very quick and intuitive means to set video to pass through without any resizing at all. As of 2.38B, I see no way to be absolutely certain that Vidcoder will not attempt to resize the video as there is no obvious "off" button.

1a. You might also consider adding a "De-Anamorph" selection so that the Vidcoder encodes the video at it's display resolution rather than it's original resolution (i.e. 720x480 --> 640x480). I wouldn't find this very useful myself, but I can see it's utility.

(2) Make anamorphic a section separate from the sizing section. Anamorphic is resized on the display, not when encoded, so IMO it's best left separated from Sizing. In here you could have the option to a. Keep original aspect ratio, b. Keep intended aspect ratio (i.e. 4:3 in = 4:3 out even if cropped), c. A drop down of common aspect ratios, d. Allow a specific display width, and e. For the hard core, a direct PAR entry.

Apologies for the long winded report, I'm trying to be as constructive as possible...

RandomEngy commented 7 years ago

In Automatic mode it's always supposed to try and preserve the source aspect ratio, even when Anamorphic is disabled. If you're seeing the picture get stretched one way or the other, send me an encode log and I'll take a look at it.

As far as the "none" sizing mode, you can turn off cropping, use Downscale Only with no max width or height and enable Anamorphic. Or the "normal" preset with cropping turned off.

As for an option for keeping the "intented" aspect ratio, maybe? When I'm encoding video I first and foremost want to keep the image from getting squashed. I don't know what devices it will play on down the line, and there's no good reason to force something to fit in a 4:3 ratio when it's playing on a 16:9 screen. Would you want something that detected when your video was pretty close to a standard aspect ratio and squashed it a bit to make it fit?

684848484574 commented 7 years ago

Hello, sorry for delay. I'm so used to being ignored online that I just assume nobody is reading or interested, much less responding. In answer to your latest question: I am not saying the latest settings don't maintain the PAR. And I was referring to 4:3 not 16:9. I'm probably wrong for doing this but when I run into a 4:3 that needs padding to fill out the 4:3, I generally change the PAR by squishing the top and bottom of frame to force the left and right to fill out the 4:3. From an idiot's point of view (i.e. me), I think something is wrong when I see a thin layer of black on the left and right of video and then another shade of black filling the rest of the screen during playback. Strangely, this thin layer of black on the left and right on 16:9 seems alright and I don't try to remove it unless there is a thick black bar on one side of the frame but not on the other. Then I feel very compelled to crop it and adjust the top and bottom to fill . I would even propose that cropping the upper and lower black on 2.35:1 is unnecessary. Occasionally it works out just fine, but just as often leaving 2.35:1 in its original 1.78:1 yields a better picture with better compression. But sometimes it does not. I know there is a furious debate on whether cropping the black is better or not. Unfortunately for science, the answer is sometimes it is and sometimes it's not.

I guess since I don't believe that the mastering of DVDs is always correct, I have little interest in preserving the OAR, as per my explanation of 2.2:1 DAR from 1.33:1 OAR. I guess I don't worry about it so much because of my changing the 720 width to 704 right from the get-go. I already know the PAR isn't going to be 1:1.

Regarding the new Vidcoder settings, I am still unsure and my opinion has changed somewhat since my feedback. What I was referring to is this: Lets say I automatically crop the picture in vidcoder and have already set the anamorph to loose with mod16. Instead of getting the dimensions 853x480, I get 835x480. In the new version, there is no way to change this to 853. But is that a good thing? Maybe, I don't know.,

On 11/7/16, RandomEngy notifications@github.com wrote:

It should still work with Anamorphic content just fine, I was testing extensively with letterboxed anamorphic DVD content when I wrote the feature. What happens when you choose Downscale Only and remove the max width and max height? Its aim is to preserve the original picture and tweak the PAR such that the original picture aspect ratio is maintained.

I'm trying to understand if you're saying that either A) The new settings don't maintain the picture aspect ratio OR B) Some content has an incorrect aspect ratio and VidCoder doesn't let you correct for this

If you'd like, you can send me a clip of the DVD you're trying to work with and I can see if VidCoder has an issue handling it. You could create one to share by taking the Normal preset and removing cropping. It would also be helpful to get a copy of the old preset that you liked by running a portable version of the old version and exporting it.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/RandomEngy/VidCoder/issues/140#issuecomment-258872730

RandomEngy commented 7 years ago

Can you provide an encode log of where you expected it to be 853 and it turned out different? It would let me see the situation you're talking about more clearly.

684848484574 commented 7 years ago

I understand what you want, although I don't know if a log will articulate it as easily as pics. I attached two pics. The first shows the width and height after cropping the black on the right and left. The second pic shows what happens when you resize the top and bottom. Instead of the width changing (like it used to), the height changes. In the past, the second pic would show 853 width and 480 height. Now it has 834 width and 470 height. I'm not even arguing that this is wrong or bad. I don't know. It would seem correct that if we crop 8 from both sides of frame that width would be 834 instead of 853, and that if you crop 6 from the top and bottom the height would change to 468, but I'm just saying that in the past, cropping the top and bottom changed the width and not the height...and this allowed me to fix poorly mastered dvds but also opens up the possibility of messing up correctly mastered dvds. If cropping the top and bottom changed the width to 853, that doesn't necessarily mean it should be done...Before this version of vid coder, that was exactly what I was doing. Now I am thinking I was wrong.

On Thu, Nov 24, 2016 at 12:14 PM, RandomEngy notifications@github.com wrote:

Can you provide an encode log of where you expected it to be 853 and it turned out different? It would let me see the situation you're talking about more clearly.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/RandomEngy/VidCoder/issues/140#issuecomment-262820195, or mute the thread https://github.com/notifications/unsubscribe-auth/ATgFPYPum0NKHQcPYqyTcNOb8DNCte3kks5rBcXxgaJpZM4KrB5D .

RandomEngy commented 7 years ago

It looks like the pictures didn't make it through on the email reply. Can you try putting them in the GitHub issue directly?