RandomEngy / VidCoder

A Blu-ray, DVD and video file transcoder for Windows.
http://vidcoder.net
GNU General Public License v2.0
685 stars 42 forks source link

Add XAML islands support in Microsoft Store release #660

Open EP012014 opened 4 years ago

EP012014 commented 4 years ago

Add XAML islands support in Microsoft Store release to make it match fluent design

RandomEngy commented 4 years ago

XAML islands is there to allow you to put XAML UI into non-XAML applications.

But VidCoder is already all entirely XAML. What do you mean by "match fluent design"? Is there some particular part of the UI that you think needs to be changed?

EP012014 commented 4 years ago

XAML islands is there to allow you to put XAML UI into non-XAML applications.

But VidCoder is already all entirely XAML. What do you mean by "match fluent design"? Is there some particular part of the UI that you think needs to be changed?

Starting in Windows 10, version 1903, you can host UWP controls in non-UWP desktop applications using a feature called XAML Islands. This feature enables you to enhance the look, feel, and functionality of your existing WPF, Windows Forms, and C++ Win32 applications with the latest Windows 10 UI features that are only available via UWP controls.

EP012014 commented 4 years ago

XAML islands is there to allow you to put XAML UI into non-XAML applications. But VidCoder is already all entirely XAML. What do you mean by "match fluent design"? Is there some particular part of the UI that you think needs to be changed?

Starting in Windows 10, version 1903, you can host UWP controls in non-UWP desktop applications using a feature called XAML Islands. This feature enables you to enhance the look, feel, and functionality of your existing WPF, Windows Forms, and C++ Win32 applications with the latest Windows 10 UI features that are only available via UWP controls.

That means, it's the UWPlization of the UI (e.g. acrylic, reveal style buttons, UWPLized progressbars / progrossrings).

RandomEngy commented 4 years ago

Seems like a lot of work (and potential performance overhead) for not a ton of gain. Is there any particular part of the UI that looks bad to you?

I think I might use this if there was a particular UI control I wanted to use but was only available as UWP. But probably not as a sweeping overhaul of the app.

ArtexJay commented 1 year ago

Well now they are moving away from UWP to WinUI3.1 which is still based om XAML islands however should be lighter than UWP as well as delivering the new Mica effect and the new UI design on Win11, it is also no longer dependent on being in MS Store like previous UWP apps. I think this can be implemented slowly overtime when/if there is time to beautify the app. It's not a must but it would look really nice.

RandomEngy commented 1 year ago

There might be a few advantages; but a total app conversion would (in aggregate) be a whole lot of work. It's something I would accept PRs on; but not something that I want to take on myself. I have a lot of other projects that would get a lot more accomplished for the same amount of work.