search

RandomEngy / fcm-push-listener

17 stars 1 forks source link

Token refresh & renewal #4

Open unreadablewxy opened 5 months ago

unreadablewxy commented 5 months ago

Unsure about this topic but I read that FCM tokens can go stale and require refresh, current registration logic do not allow for this. Recommend splitting key creation from registration initiation & add a function for token renewal that can accept secrets as input.

Is this concern valid?

RandomEngy commented 5 months ago

That sounds like a valid concern to me. FCM token expiration is not something the current library takes into account. It sounds like there would also need to be some way to tell if a token needed to be renewed in that case.

I'm not sure if we'd have to split the key creation out from the registration step. The new method could take an existing Registration struct to re-use the keys in it.