search

RandomFractals / vscode-data-preview

Data Preview 🈸 extension for importing 📤 viewing 🔎 slicing 🔪 dicing 🎲 charting 📊 & exporting 📥 large JSON array/config, YAML, Apache Arrow, Avro, Parquet & Excel data files
https://marketplace.visualstudio.com/items?itemName=RandomFractalsInc.vscode-data-preview
Apache License 2.0
553 stars 58 forks source link

can't to open files on Windows 10 (TBD) #141

Closed S-Maciejewski closed 5 years ago

S-Maciejewski commented 5 years ago

The extension is really useful, however I encountered a bug similar to the one mentioned in issue #124 - the extension doesn't see the file I'm trying to open, except this issue is occuring on Windows 10 (version 1903). It used to work previously (a few versions back, 1.3x.0), but I can't fix it since. Tried reinstalling the extension and VS Code itself, nothing helped. Would appreciate help with this one, becouse as I said, extension proves to be really useful :) image

RandomFractals commented 5 years ago

agh! I must have broke it again in my last refactor. sorry about that.

I'll add some tests and will try it on my win10 lappy.

Looks like you are using vscode v1.37?

Thanks for letting me know.

S-Maciejewski commented 5 years ago

I'm using VS Code v1.37.1, thanks!

RandomFractals commented 5 years ago

@S-Maciejewski btw, I am hoping to get to this soon, but have you tried vscode v1.38?

There were quite a few things broken in that v1.37.1 release related to webviews restore and fs/uri api changes.

Can you see if this was patched up in that vscode v1.38 released yesterday too?

https://twitter.com/code/status/1169310819894476803

sbgillett commented 5 years ago

Same issue in 1.38 here I'm afraid

RandomFractals commented 5 years ago

@sbgillett ok will try to patch it soon. thx for checking

RandomFractals commented 5 years ago

@S-Maciejewski & @sbgillett: quick follow up q. on this:

how are you trying to launch data.preview on your win10s? there are like half a dozen of ways to do it:

https://github.com/RandomFractals/vscode-data-preview#data-preview--launch-tips

are you saying none of them work for you?

I could use more info on that to close this. thanks!

also, if you dev (I can't tell by your sparse github profile :) you can try this & let me know how it fairs in your dev debug sesss. : https://github.com/RandomFractals/vscode-data-preview#dev-build

@aviaconstructor did that in our last files 404 & we patched it fast for his Linux ;)

twsl commented 5 years ago

Same here, neigher starting the data preview via command palette nor using the dedicated icon seems to work. Using the version 1.38.0. Is there anything else you need? If I can find some time, I'll try the debug build

RandomFractals commented 5 years ago

@twsI yeah, try the ext. dev/debug build & run. you should get more msgs on paths for data files loading, if you have time.

I'll look into this too. I def. want it to work on win10. thanks!

RandomFractals commented 5 years ago

@S-Maciejewski @sbgillett & @twsI hey guys, I just pushed new v1.41 that hopefully fixes this issue.

If not I'll have to dive deeper into vscode Uri implementation which is a bit wonky.

Let me know if this is resolved for your win10 builds & please don't forget to star & provide feedback in store: https://marketplace.visualstudio.com/items?itemName=RandomFractalsInc.vscode-data-preview&ssr=false#review-details

RandomFractals commented 5 years ago

alternatively, I am considering switching to new vscode.worspace.fs api which provides support for remote data files too: https://github.com/microsoft/vscode/issues/78094

sbgillett commented 5 years ago

Sorry but still not working for me following update to v1.41. Let me know if I can do anything to provide further details.

RandomFractals commented 5 years ago

hah! ok. I think I'll be switching to new vscode.workspace.fs api then.

RandomFractals commented 5 years ago

@sbgillett actually, can you try one of the data files from my sample/test folder: https://github.com/RandomFractals/vscode-data-preview/tree/master/data/json

I just had devs confirm that it works on mac & works on my win7 machine. I really don't see why this would be an issue on win10.

Thanks!

RandomFractals commented 5 years ago

I am closing this issues since I can't reproduce it. Please try a different data file.

vscode-data-preview-win10
twsl commented 5 years ago

Can confirm, that the latest version is now working for me on win10 too

RandomFractals commented 5 years ago

@twsI wow! the diff. between Uri.file & parse, eh? sorry it took a few days to look into it and patch. I also confirmed it works in vscode v1.38 on win10. also, I am not gonna link to the open issues since 2016 for uri parse and others in vscode repo. Let me just say this wasn't fun to troubleshoot :)

RandomFractals commented 5 years ago

p.s.: if you feel like this is a solid data ext for vscode, please star it here:

https://marketplace.visualstudio.com/items?itemName=RandomFractalsInc.vscode-data-preview&ssr=false#review-details

I could use more stars in that degraded feedback ;)

thanks for checking it out too & sticking with me through this recon.