RandomFractals / vscode-data-table

Data Table 🈸 , Flat Data Grid 中 & Data Summary 🈷️ Renderers for VSCode Notebook 📓 Cell ⌗ Data Outputs
https://marketplace.visualstudio.com/items?itemName=RandomFractalsInc.vscode-data-table
Apache License 2.0
25 stars 5 forks source link

Json download doesn't work #147

Open richiesgr opened 1 year ago

richiesgr commented 1 year ago

Hi when I use download as CSV all is ok but the JSON button doesn't work any idea why ? Thanks

RandomFractals commented 1 year ago

@richiesgr is that in Flat Data Grid renderer? That's the only renderer that provides CSV and JSON download options in this data table renderers extension. It uses github's flat data viewer. See related renderer info in docs: https://github.com/RandomFractals/vscode-data-table#flat-data-%E4%B8%AD-grid-renderer

Please provide a screenshot of the renderer you are using and the errors you get when you go to Help -> Toggle Developer Tools in VSCode to review and troubleshoot it.

ajshedivy commented 4 months ago

Hi @RandomFractals, I am also running into this issue with exporting the rendered table as JSON when using the Flat Data Grid. To recreate open the iris-vega-data.ipynb and run the first cell, then change the presentation to Flat Data Grid, then export the chat as JSON. No errors appear on screen. Here is view of the dev console after going through those steps: image

Edit: CSV export works just fine

RandomFractals commented 4 months ago

@ajshedivy will need to investigate this further with the latest version of flat data viewer library and changes in VS Code notebooks rendering API after this extension was published. Thanks for the output error screenshot!