RandomFractals / vscode-data-table

Data Table 🈸 , Flat Data Grid 中 & Data Summary 🈷️ Renderers for VSCode Notebook 📓 Cell ⌗ Data Outputs
https://marketplace.visualstudio.com/items?itemName=RandomFractalsInc.vscode-data-table
Apache License 2.0
25 stars 5 forks source link

Current forced small row height in Flat Data Grid obscures underscores and descender parts of text #157

Open entact-vhorvath opened 10 months ago

entact-vhorvath commented 10 months ago

The current line height obscures important textual information (underscores). This is vital for applications where data contains underscores, e.g. XML based data formats.

Using your examples one can see that the part of the text falling under the baseline is now invisible, see note field, e.g. _untitled_19:

image

Please consider adding:

.github-octo-flat-ui {
  line-height: 1.0 !important;
}

Result: image

RandomFractals commented 10 months ago

@entact-vhorvath yes, I did not notice this when I reduced row height to display more rows. Will reduce the default font size in the next update to patch this.

entact-vhorvath commented 10 months ago

Perhaps it would be useful to give users the option to change this setting via the VSCode settings interface. Could be a few profiles that would allow users to pick from font sizes and packing of the rows (line heights), or a direct mapping between CSS values, whatever better fits the purpose. This extension might be combined with others and it is hard to inject a CSS rule from the outside, config seems to be a better way where you also can sanitize input.