search

RandomMcSomethin / fallingleaves

MIT License
43 stars 20 forks source link

Terrestria Redwood Leaves are not registered as a LeavesBlock #17

Closed Fourmisain closed 3 years ago

Fourmisain commented 3 years ago

terrestria:redwood_leaves are not registered as a LeavesBlock but as a TerrestriaOptiLeavesBlock, which extends from ExtendedLeavesBlock (from Terraform) which just extends from Block.

There's also a reference to it in resources/data/minecraft/tags/blocks/leaves.json, so I wonder if that's a vanilla minecraft thing and if we can add support for it.

Another way would of course open an issue with Terraform.

Fourmisain commented 3 years ago

That was fast, so Terraform can't change it (without breaking other stuff), so we should really be using the leaves tag if we can.

Fourmisain commented 3 years ago

Fixed with https://github.com/RandomMcSomethin/fallingleaves/commit/ce13332f6ce0584aca3297f02468264b63303cbd.

Leaf block detection now also uses the LEAVES block tag, but we still require LeavesBlock.randomDisplayTick() to be called, which at the very least is true for Terraform's ExtendedLeavesBlock.