search

RandomMcSomethin / fallingleaves

MIT License
43 stars 20 forks source link

Option in Sodium Extra (optional) #34

Closed HarvelsX closed 2 years ago

HarvelsX commented 2 years ago

Small PR adding the ability to simply disable the effect of this mod via Sodium Extra

Fourmisain commented 2 years ago

Hm... I'm not sure how I feel about adding this option to Sodium Extra. On one hand it does seem convenient to have it there but on the other hand, having it there suggests it's a feature of Sodium Extra, not Falling Leaves, so if something goes wrong, people might complain on the wrong end.

I also wonder about all of the other particle mods out there - should they all add their own switch to Sodium Extra? Kinda feels like Sodium Extra could do all this on their end, e.g. by filtering the particles based on their mod ID and adding a switch for each detected particle mod.

It's also not as if Falling Leaves cannot be disabled. The reason why we haven't (yet) added a disable switch is because you can just set the leaf spawn rates to 0... and the "decayed leaf max spawn count"... and actually, the registerAttackBlockLeaves() cannot currently be disabled... Okay maybe it's finally time to add that disable switch.

@BrekiTomasson @RandomMcSomethin Opinions on this?

HarvelsX commented 2 years ago

Kinda feels like Sodium Extra could do all this on their end, e.g. by filtering the particles based on their mod ID and adding a switch for each detected particle mod.

Sounds like a great idea!