RandomMcSomethin / fallingleaves

MIT License
43 stars 20 forks source link

Not *entirely* client-side? #54

Closed Wo0fle closed 1 year ago

Wo0fle commented 1 year ago

Here's the situation:

hold up

IGNORE "TCDCOMMONS", THAT'S ANOTHER MOD THAT I REMOVED ANYWAY

However, here's another situation:

I checked Mod Menu and it doesn't list Falling Leaves as "Client", but it seems like it should be.

What is going on? Is this something on my end?

Fourmisain commented 1 year ago

Falling Leaves is 100% client-side. I know because I patched it over 2 years ago #3, starting off this whole maintaining business.

I assume this is an inherent issue with the way Essential works and might also be related to some recent Fabric API change...?

When using Essential, you must be connecting to your friend's integrated server and I assume the particles Falling Leaves registers "leak" into the "server-side".

I'm not sure if there's anything we can do about that, since running a true server does allow joining with or without the mod as expected. (I double checked it right now, setup a 1.20.1 server with Falling Leaves, Fabric API and Cloth Config. Vanilla client can join. Fabric client with just Fabric API can join too.)

The easiest fix is honestly to just install the mod and turning it off - I made on-off button just for occasions like these 😄

Wo0fle commented 1 year ago

Good to know! Thanks!

Fourmisain commented 1 year ago

Just thought a little bit about it. It's definitely due to the registry "leaking" into integrated server - because client and it's integrated server use the same one registry. While it's theoretically possible to spawn particles without using the particle registry, it'd probably require a bunch of hacky code and we'd lose features like the /particle command too.

So in the end I think the best course of action is no action at all.