search

RandomMcSomethin / fallingleaves

MIT License
43 stars 20 forks source link

Snow drops when Fabric Seasons is in summer #55

Closed vico93 closed 12 months ago

vico93 commented 12 months ago

I wonder if this mod "talks" in anyway with @lucaargolo's Fabric Seasons when it's installed. When it's spring/summer on a icy biome, while the snow and ice melt the spruce trees (without a snow layer above the leaves) still give the snow effect below them. I wonder if the mod could detect the current season to stop that snowing (and put regular green particles instead).

2023-09-04_22 48 22

Fourmisain commented 12 months ago

It does "talk" to Seasons. In fall and winter, leaf spawn rates are affected.

Just checked Seasons' code. The way it melts snow is by increasing the temperature (for certain biomes) in summer. I originally tried detecting "snowy biomes" via temperature, but that was highly unreliable. I think it would probably be best to disable the "snowy villagers" check if Seasons is in summer, so that the "snow on top of trees" check can work instead.

P.S. Snow drops are independent from leaf drops and spruce are coniferous, so they wouldn't spawn any particles (by default).

Fourmisain commented 12 months ago

New version is up!

vico93 commented 12 months ago

Thanks a lot!