RandomMcSomethin / fallingleaves

MIT License
43 stars 20 forks source link

Hitting & breaking leaves still produces particles irrespective of the spawn rate #57

Closed MerpisMe closed 11 months ago

MerpisMe commented 11 months ago

the title is pretty much the gist of it; setting the spawn rate to 0 still spawns leaves when breaking or hitting leaves

Fourmisain commented 11 months ago

That is sorta the idea. The leaves are meant to signify you are breaking the block (ruffling up / cutting up the tree), just like the regular block breaking particles.

MerpisMe commented 11 months ago

i guess that's fair, though i'd still prefer if there was an option per block to toggle it

i mainly wanted to see this be fixed since i'm not the biggest fan of cherry leaves still dropping particles; the vanilla ones look far better than the tinted ones in my opinion, and i'd like to at least be able to disable it somehow (unless you lot want to make the particles just use the vanilla cherry ones instead)

Fourmisain commented 11 months ago

Okay, I think this should work...

Yep, I just added a per-block setting for the on-hit leaves, which also applies leaves on decay ("block breaking leaves").

New version is up (on Modrinth, CurseForge takes a second)!

MerpisMe commented 11 months ago

oh wow, that was really fast. thank you so much!!

Fourmisain commented 11 months ago

Would have been twice as fast if I didn't have to rethink and rename everything after remembering decay leaves are a thing... 😅