search

RandomMcSomethin / fallingleaves

MIT License
43 stars 20 forks source link

Why is bro levitating🙏🙏🙏🙏🙏🙏 #61

Closed Epik0rangutan closed 5 months ago

Epik0rangutan commented 5 months ago

What's wrong with blud

Fourmisain commented 5 months ago

Bro just doesn't want to get wet!

Fourmisain commented 5 months ago

Leaf Jesus aside for a second, the reason why the leaves don't really "fall" here is because leaves stop their vertical momentum once they collide with water and the collision check is just a rough block check: https://github.com/RandomMcSomethin/fallingleaves/blob/75b5ee6f70601d0f30ae988b9860361660106b4a/src/main/java/randommcsomethin/fallingleaves/particle/FallingLeafParticle.java#L82-L84

I remember trying to improve the water collisions ages ago, but it was still janky because the true water collisions are boxy and not as smooth as the water model suggest. Here's a very scientific illustration of what I mean: illustration The leaves would "hickup" when going from one water level to a lower one.

Looks like I didn't even feel the need to keep that experimental code around. I'll give it some more thought, maybe there's a better way of handling this.

Fourmisain commented 5 months ago

I improved the water physics a bit. Leaves should flow on water, dip up and down a bit and ascend to the heavens when they hit a water fall from the side.

New version 1.15.5 is up!