RandomNinjaAtk / arr-scripts

Extended Container Scripts - Automation scripts to make life easier!
GNU General Public License v3.0
746 stars 73 forks source link

[FEATURE] - Lidarr-Extended - Add Indexer/Download Client UI configurations #177

Open Coder84619 opened 9 months ago

Coder84619 commented 9 months ago

Is your feature request related to a problem? Please describe. When using an alternate Lidarr mod, Lidarr on Steroids, it automatically configures indexers and download clients in the Lidarr UI. The current implementation of Lidarr extended does not setup any indexers/download clients in the UI. I understand they work in the background, but having a UI would be great.

Describe the solution you'd like I would like the installation to script to configure the Lidarr indexers and download clients to point to the extended feature set your mods bring to the table. This would be very helpful for several reasons. 1) I can then monitor activity/history in the Lidarr UI 2) It removes the red system warnings about no indexers/download clients/RSS feeds. This would also let the user temporarily disable a download client/indexer through the UI.

Describe alternatives you've considered Leave it as-is, which is not as user friendly and is behind competing Lidarr mods.

Additional context Other Lidarr mod containers DO modify the UI to add their own custom Indexers/Download clients. Lidar Extended is by the far best in terms of functionality, but is just missing the Lidarr UI visibility. This would also allow functions like searching indexers for matches/tracks to work.

RandomNinjaAtk commented 9 months ago

PR welcome…

Coder84619 commented 9 months ago

@RandomNinjaAtk Well I don't know the first thing about programming, so would be impossible for me to submit any updates.

hockeygoalie35 commented 9 months ago

@Coder84619 From what I understand, this would require alterations to Lidarr's code. The point of this repo is to easily add the functionality but keeping Lidarr itself untouched. This makes it (mostly) version agnostic, and is much easier to setup from a failed harddrive, etc.

Coder84619 commented 9 months ago

@hockeygoalie35 I totally understand not wanting to modify the Lidarr code base...makes perfect sense for maintenance. There is a "plugin" enabled branch of Lidarr (lidarr:pr-plugins by hotio), which the deemix plugin uses to integrate into the Lidarr UI. Hotio maintains the plugin branch and it's current. According to Lidarr Discord the "plugin" fork allows a modification-free way to add the Deemix index/download UI features and not burden @RandomNinjaAtk with a maintenance nightmare.

The deemix plugin code is at: https://github.com/ta264/Lidarr.Plugin.Deemix Hotio container: image: ghcr.io/hotio/lidarr:pr-plugins

It probably wouldn't take a coder too long to review the ta264 code and see how they integrate with Lidarr's plugin fork.

From a pined messaged on the Lidarr Discord:

Change to the plugins branch (change your branch in Settings / General, or pull the pr-plugins hotio container).
[...] Back to Lidarr: Go into System / Plugins, and paste this URL into the plugins section: https://github.com/ta264/Lidarr.Plugin.Deemix

From Discord:

Q: Does the plugin branch allow a dev to easily add indexers/download clients without modifying the Lidarr code base? A: Yes. If by easily you mean using c# to write an implementation following are plugin requirements then yes.

RandomNinjaAtk commented 9 months ago

PR Welcome, I can tell you that this is something I have no plans to work on, due to time, effort and skill required. Also if it ain't broke, don't fix it....

Coder84619 commented 9 months ago

@RandomNinjaAtk Understood and appreciate the response. I'm not a coder, but maybe someone who is might find value in the modification. I do think it has value, as you can much more easily monitor the download queue status, disable all downloading via UI, and do track lookups as well. Your LIdarr mods are awesome.

RandomNinjaAtk commented 3 months ago

FYI, you can now see downloads in the gui sort of…

But that is slot about as far as I’m going to take it