search

RandomNinjaAtk / arr-scripts

Extended Container Scripts - Automation scripts to make life easier!
GNU General Public License v3.0
670 stars 70 forks source link

[FEATURE] - LIDARR - Don't overwrite tidal-dl.json during init #300

Closed JamieWritesCode closed 1 week ago

JamieWritesCode commented 3 weeks ago

Is your feature request related to a problem? Please describe.

Recently, I wanted to make some changes to the tidal-dl.json config but discovered it gets overwritten on every server restart. Is there a good reason for this? I noticed in the init script that there's existing checks to not overwrite the beets config, but not tidal-dl or deemix.

Describe the solution you'd like

Check for the existence of tidal-dl.json during init and only download it if it doesn't exist.

Describe alternatives you've considered

I looked at editing the version of this config that gets copied into the xdg folder instead but it seems like this gets replaced every restart as well.

Additional context

Mostly just posting here to check for any unforseen consequences. I've already implemented this on my own server and I'm happy to write the pull request if there's no good reason not to overwrite this config every boot.

JamieWritesCode commented 3 weeks ago 
if [ ! -f /config/extended/tidal-dl.json ]; then
    echo "Download Tidal config..."
    curl "https://raw.githubusercontent.com/RandomNinjaAtk/arr-scripts/main/lidarr/tidal-dl.json" -o /config/extended/tidal-dl.json
    echo "Done"
fi