search

RandomNinjaAtk / docker-lidarr-extended

lidarr-extended :: Lidarr application packaged with multiple scripts to provide additional functionality
GNU General Public License v3.0
275 stars 24 forks source link

[Feat]: allow setting custom deezer "notfound" retry time #150

Closed s1nnerman89 closed 1 year ago

s1nnerman89 commented 1 year ago

Is your feature request related to a problem? Please describe.

I'm not sure why the script waits 90 days before searching again for previously "notfound" releases. If there is no specific reason behind this choice, i believe that adding an option for a custom waiting time should help with missed releases.

Describe the solution you'd like

Change the "+90" setting (line 260 of Audio.sh) to a variable (something like $deezerNotfoundRetryWait, expressed in days) which can be passed as an environment variable, letting it default to 90 days unless specified.

Describe alternatives you've considered

Since it is a pretty straightforward and simple change, i don't think that there are simpler solutions other than the one i proposed.

Additional context

No further context is needed.

RandomNinjaAtk commented 1 year ago

Would be a fairly simple change, however, not sure it will help that much because its not like things suddenly become available if it wasn't previously. Unless you just want to force it to retry and possibly end up with the same result.

RandomNinjaAtk commented 1 year ago

This should now be implemented add -e retryNotFound=90 to your config, give it a try. May have to wait a bit for the image to update with the changes... This is untested.... but should work....

s1nnerman89 commented 1 year ago

Unless you just want to force it to retry and possibly end up with the same result.

That is exactly why i proposed the change: sometimes lidarr says that a release is available but Audio.sh fails to grab it. Checking the availability on deezer's site confirms that the album/song/etc. was released.

I don't know if this behaviour is due to Audio.sh, lidarr or the search algorithm, but to me, at least, happens pretty frequently: just yesterday i had a problem with a song that was released some days ago; it was marked as notfound on release day. I deleted the notfound log associated with the song, launched Audio.sh again and the song was correctly grabbed.

This should now be implemented add -e retryNotFound=90 to your config, give it a try.

Will do and let you know in this thread of eventual bugs. Thanks for listening to my suggestion and quickly implementing it.