search

RandomNinjaAtk / docker-lidarr-extended

lidarr-extended :: Lidarr application packaged with multiple scripts to provide additional functionality
GNU General Public License v3.0
275 stars 24 forks source link

[Feat]: Anyway to utalise the converter? #69

Closed elit3ge closed 1 year ago

elit3ge commented 2 years ago

Describe the solution you'd like Is there a way to use the converter included in Extended to convert say FLAC to MP3 upon import when not using TIDAL?

RandomNinjaAtk commented 2 years ago

Set your settings to mp3 and it should already do that... Before import

elit3ge commented 1 year ago

Hmmm. I've got it set to MP3 360, still seems to be importing the FLAC.

elit3ge commented 1 year ago

Or would requireQuality=true need to be set?

RandomNinjaAtk commented 1 year ago

Can you post some log output from when the script starts? Should show what settings you've configured...

elit3ge commented 1 year ago 

2022-09-21 06:00:09 :: Extended Audio ::  |~) _ ._ _| _ ._ _ |\ |o._ o _ |~|_|_|
2022-09-21 06:00:09 :: Extended Audio ::  |~\(_|| |(_|(_)| | || \||| |_|(_||~| | |<
2022-09-21 06:00:09 :: Extended Audio ::  Presents: lidarr-extended (1.0.246)
2022-09-21 06:00:09 :: Extended Audio ::  Docker Version: amd64-1.0.29
2022-09-21 06:00:09 :: Extended Audio ::  May the beats be with you!
2022-09-21 06:00:09 :: Extended Audio :: -----------------------------------------------------------------------------
2022-09-21 06:00:09 :: Extended Audio :: Donate: https://github.com/sponsors/RandomNinjaAtk
2022-09-21 06:00:09 :: Extended Audio :: Project: https://github.com/RandomNinjaAtk/docker-lidarr-extended
2022-09-21 06:00:09 :: Extended Audio :: Support: https://github.com/RandomNinjaAtk/docker-lidarr-extended/discussions
2022-09-21 06:00:09 :: Extended Audio :: -----------------------------------------------------------------------------
2022-09-21 06:00:14 :: Extended Audio :: 
2022-09-21 06:00:14 :: Extended Audio :: Lift off in...
2022-09-21 06:00:14 :: Extended Audio :: 5
2022-09-21 06:00:15 :: Extended Audio :: 4
2022-09-21 06:00:16 :: Extended Audio :: 3
2022-09-21 06:00:17 :: Extended Audio :: 2
2022-09-21 06:00:18 :: Extended Audio :: 1
2022-09-21 06:00:19 :: Extended Audio :: To kill script, use the following command:
2022-09-21 06:00:19 :: Extended Audio :: kill -9 189
2022-09-21 06:00:19 :: Extended Audio :: kill -9 189
2022-09-21 06:00:22 :: Extended Audio :: Lidarr Version: 1.1.0.2649
2022-09-21 06:00:22 :: Extended Audio :: Add Deezer Top Artists is disabled (enable by setting addDeezerTopArtists=true)
2022-09-21 06:00:22 :: Extended Audio :: Add Deezer Top Album Artists is disabled (enable by setting addDeezerTopAlbumArtists=true)
2022-09-21 06:00:22 :: Extended Audio :: Add Deezer Top Track Artists is disabled (enable by setting addDeezerTopTrackArtists=true)
2022-09-21 06:00:22 :: Extended Audio :: Add Deezer Related Artists is disabled (enable by setting addRelatedArtists=true)
2022-09-21 06:00:22 :: Extended Audio :: Configure Lidarr with optimal settings is disabled (enable by setting configureLidarrWithOptimalSettings=true)
2022-09-21 06:00:22 :: Extended Audio :: Download Location :: /downloads-lidarr-extended
2022-09-21 06:00:22 :: Extended Audio :: Output format = mp3
2022-09-21 06:00:22 :: Extended Audio :: Output bitrate = 320
2022-09-21 06:00:22 :: Extended Audio :: Download Quality Check Enabled
2022-09-21 06:00:22 :: Extended Audio :: Preferred audio lyric type: both
2022-09-21 06:00:22 :: Extended Audio :: Tidal Country Code set to: AU
2022-09-21 06:00:22 :: Extended Audio :: Replaygain Tagging Enabled
2022-09-21 06:00:22 :: Extended Audio :: Removing prevously completed downloads that failed to import...
2022-09-21 06:00:24 :: Extended Audio :: TIDAL :: Verifying tidal-dl configuration
2022-09-21 06:00:24 :: Extended Audio :: TIDAL :: No default config found, importing default config "tidal.json"
2022-09-21 06:00:27 :: Extended Audio :: TIDAL :: Purging album list cache...
2022-09-21 06:00:27 :: Extended Audio :: TIDAL :: Upgrade tidal-dl to newer version...```
RandomNinjaAtk commented 1 year ago

Thx, what I thought I suspected was not it. I'll have to look into it a bit more, cause it looks like it should be working... It's not something I use myself so it has considerably less testing...

RandomNinjaAtk commented 1 year ago

@elit3ge The latest update, after its done building, should fix the issues you were seeing, give it a test and report back.

elit3ge commented 1 year ago

Okay, I might be doing something wrong, but I can't seem to get it to work. Still importing FLAC.

RandomNinjaAtk commented 1 year ago

You need to post some log data from the script, when it downloads a release and processes it. Without seeing the log data, no way to know what is happening...

elit3ge commented 1 year ago

from Lidarr.txt

2022-10-02 14:16:54.6|Info|NzbSearchService|Searching indexers for [Slipknot - All Hope Is Gone (2008)]. 8 active indexers
2022-10-02 14:16:57.6|Info|DownloadDecisionMaker|Processing 117 releases
2022-10-02 14:17:30.3|Info|DownloadService|Report sent to qBittorrent. Slipknot All Hope Is Gone 2008 FLAC+CUE [RLG]
2022-10-02 14:18:35.1|Info|RssSyncService|Starting RSS Sync
2022-10-02 14:18:43.6|Info|DownloadDecisionMaker|Processing 316 releases
2022-10-02 14:18:51.5|Info|RssSyncService|RSS Sync Completed. Reports found: 316, Reports grabbed: 0
2022-10-02 14:19:30.7|Info|Lidarr.Http.Authentication.ApiKeyAuthenticationHandler|AuthenticationScheme: API was challenged.
2022-10-02 14:22:36.5|Info|ImportDecisionMaker|Reading file 1/12
2022-10-02 14:22:36.5|Info|ImportDecisionMaker|Reading file 2/12
2022-10-02 14:22:36.5|Info|ImportDecisionMaker|Reading file 3/12
2022-10-02 14:22:36.5|Info|ImportDecisionMaker|Reading file 4/12
2022-10-02 14:22:36.5|Info|ImportDecisionMaker|Reading file 5/12
2022-10-02 14:22:36.5|Info|ImportDecisionMaker|Reading file 6/12
2022-10-02 14:22:36.6|Info|ImportDecisionMaker|Reading file 7/12
2022-10-02 14:22:36.6|Info|ImportDecisionMaker|Reading file 8/12
2022-10-02 14:22:36.6|Info|ImportDecisionMaker|Reading file 9/12
2022-10-02 14:22:36.6|Info|ImportDecisionMaker|Reading file 10/12
2022-10-02 14:22:36.6|Info|ImportDecisionMaker|Reading file 11/12
2022-10-02 14:22:36.6|Info|ImportDecisionMaker|Reading file 12/12
2022-10-02 14:22:36.6|Info|TrackGroupingService|Grouping 12 tracks
2022-10-02 14:22:36.6|Info|IdentificationService|Identifying album 1/1
2022-10-02 14:22:37.0|Info|ImportApprovedTracks|Importing album 1/1
2022-10-02 14:22:37.6|Info|ImportApprovedTracks|Importing 12 tracks

From MetadataPostProcess.txt

2022-10-02 14:22:38 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008]/01. Slipknot - .execute.flac
2022-10-02 14:22:39 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008] :: Album Artwork Extracted to: /music/Slipknot/All Hope Is Gone [2008]/folder.jpg
2022-10-02 14:22:40 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008]/02. Slipknot - Gematria The Killing Name.flac
2022-10-02 14:22:41 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008]/03. Slipknot - Sulfur.flac
2022-10-02 14:22:41 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008]/04. Slipknot - Psychosocial.flac
2022-10-02 14:22:42 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008]/05. Slipknot - Dead Memories.flac
2022-10-02 14:22:43 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008]/06. Slipknot - Vendetta.flac
2022-10-02 14:22:43 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008]/07. Slipknot - Butchers Hook.flac
2022-10-02 14:22:44 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008]/08. Slipknot - Gehenna.flac
2022-10-02 14:22:44 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008]/09. Slipknot - This Cold Black.flac
2022-10-02 14:22:45 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008]/10. Slipknot - Wherein Lies Continue.flac
2022-10-02 14:22:46 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008]/11. Slipknot - Snuff.flac
2022-10-02 14:22:46 :: Lidarr :: Processing :: /music/Slipknot/All Hope Is Gone [2008]/12. Slipknot - All Hope Is Gone.flac
RandomNinjaAtk commented 1 year ago

You need to post the script log data, not those... So same log you used for your earlier post. Conversion happens before lidarr imports the album... MetadataPostProcessor runs after a album is imported.

elit3ge commented 1 year ago

The extended script isn't being called by the looks of things. The album was imported at 14:22 the next script run was 14:26.

2022-10-02 14:26:12 :: Extended Audio :: -----------------------------------------------------------------------------
2022-10-02 14:26:12 :: Extended Audio ::  |~) _ ._ _| _ ._ _ |\ |o._ o _ |~|_|_|
2022-10-02 14:26:12 :: Extended Audio ::  |~\(_|| |(_|(_)| | || \||| |_|(_||~| | |<
2022-10-02 14:26:12 :: Extended Audio ::  Presents: lidarr-extended (1.0.253)
2022-10-02 14:26:12 :: Extended Audio ::  Docker Version: amd64-1.0.32
2022-10-02 14:26:12 :: Extended Audio ::  May the beats be with you!
2022-10-02 14:26:12 :: Extended Audio :: -----------------------------------------------------------------------------
2022-10-02 14:26:12 :: Extended Audio :: Donate: https://github.com/sponsors/RandomNinjaAtk
2022-10-02 14:26:12 :: Extended Audio :: Project: https://github.com/RandomNinjaAtk/docker-lidarr-extended
2022-10-02 14:26:12 :: Extended Audio :: Support: https://github.com/RandomNinjaAtk/docker-lidarr-extended/discussions
2022-10-02 14:26:12 :: Extended Audio :: -----------------------------------------------------------------------------
2022-10-02 14:26:17 :: Extended Audio :: 
2022-10-02 14:26:17 :: Extended Audio :: Lift off in...
2022-10-02 14:26:18 :: Extended Audio :: 5
2022-10-02 14:26:19 :: Extended Audio :: 4
2022-10-02 14:26:20 :: Extended Audio :: 3
2022-10-02 14:26:21 :: Extended Audio :: 2
2022-10-02 14:26:22 :: Extended Audio :: 1
2022-10-02 14:26:23 :: Extended Audio :: To kill script, use the following command:
2022-10-02 14:26:23 :: Extended Audio :: kill -9 199
2022-10-02 14:26:23 :: Extended Audio :: kill -9 199
2022-10-02 14:26:25 :: Extended Audio :: Lidarr Version: 1.1.0.2649
2022-10-02 14:26:25 :: Extended Audio :: Add Deezer Top Artists is disabled (enable by setting addDeezerTopArtists=true)
2022-10-02 14:26:25 :: Extended Audio :: Add Deezer Top Album Artists is disabled (enable by setting addDeezerTopAlbumArtists=true)
2022-10-02 14:26:25 :: Extended Audio :: Add Deezer Top Track Artists is disabled (enable by setting addDeezerTopTrackArtists=true)
2022-10-02 14:26:25 :: Extended Audio :: Add Deezer Related Artists is disabled (enable by setting addRelatedArtists=true)
2022-10-02 14:26:25 :: Extended Audio :: Configure Lidarr with optimal settings is disabled (enable by setting configureLidarrWithOptimalSettings=true)
2022-10-02 14:26:25 :: Extended Audio :: Download Location: /downloads-lidarr-extended
2022-10-02 14:26:25 :: Extended Audio :: Output format: mp3
2022-10-02 14:26:25 :: Extended Audio :: Output bitrate: 320k
2022-10-02 14:26:25 :: Extended Audio :: Download Quality Check Enabled
2022-10-02 14:26:25 :: Extended Audio :: Preferred audio lyric type: both
2022-10-02 14:26:25 :: Extended Audio :: Tidal Country Code set to: AU
2022-10-02 14:26:25 :: Extended Audio :: Replaygain Tagging Enabled
2022-10-02 14:26:25 :: Extended Audio :: Match Distance: 5
2022-10-02 14:26:25 :: Extended Audio :: Removing prevously completed downloads that failed to import...
2022-10-02 14:26:28 :: Extended Audio :: TIDAL :: Verifying tidal-dl configuration
2022-10-02 14:26:28 :: Extended Audio :: TIDAL :: No default config found, importing default config "tidal.json"
2022-10-02 14:26:30 :: Extended Audio :: TIDAL :: Purging album list cache...
2022-10-02 14:26:30 :: Extended Audio :: TIDAL :: Upgrade tidal-dl to newer version...
2022-10-02 14:26:38 :: Extended Audio :: FINDING MISSING ALBUMS :: sorted by date
2022-10-02 14:26:38 :: Extended Audio :: Downloading page 1... (0 - 339 of 339 Results)
2022-10-02 14:26:42 :: Extended Audio :: 0 MISSING ALBUMS FOUND
2022-10-02 14:26:43 :: Extended Audio :: FINDING CUTOFF ALBUMS sorted by date
2022-10-02 14:26:43 :: Extended Audio :: 0 CUTOFF ALBUMS FOUND
2022-10-02 14:26:43 :: Extended Audio :: Searching for 0 items
2022-10-02 14:26:43 :: Extended Audio :: No items to find, end
2022-10-02 14:26:43 :: Extended Audio :: Script end...
RandomNinjaAtk commented 1 year ago

Your script output indicates it already searched for everything your looking for, so there is nothing to do. You'll need to add more artists or wanted albums for it to find new content and produce the log output that is needed.

elit3ge commented 1 year ago

It's to do with converting FLAC when downloading from, say, Prowlarr (NZBGet), not TIDAL.

RandomNinjaAtk commented 1 year ago

That is not a function of this script, I miss read/understood the original request.

If using usenet, consider pre-converting using something like sabnzbd-extended.

RandomNinjaAtk commented 1 year ago

Generally converting after import is a bad idea because the files are being tracked by Lidarr. That would be the only way to include the functionality your looking for, my best suggestion is to pre-convert with something like sabnzbd-extended, or source files that match your desired quality. (There was a bug with the original conversion process with the main script that was fixed)