search

RandomityGuy / MBHaxe

A Haxe port of Marble Blast Gold, Platinum and Ultra with 99% identical physics and cross platform multiplayer, runs on Windows, Mac, Web and Android!
MIT License
73 stars 8 forks source link

MBP - Make end screen gold/ultimate colors consistent with the rest of the menus #12

Closed thearst3rd closed 1 year ago

thearst3rd commented 1 year ago

This is a subjective commit, and might deviate from vanilla MBP (I haven't checked), so feel free to reject it if you don't want it. The EndGameGui challenge time colors looked wrong, particularly Gold times actually looked more orange than Ultimate times which made them hard to differentiate.

I confirmed that FFFF00 for gold, FFCC33 for ultimate, and CCCCCC for platinum are the colors used by PQ, and they are the colors used by the PlayMissionGui in MBHaxe. So I updated the EndGameGui to use those same colors as well.

Comparisons:

Before After
image image
image image

The gold times are much easier to read on the orange background, and easier to tell it's the "gold" time by the color. Maybe though, the ultimate times are a bit harder to read, since I made them slightly less bright and the orange-on-orange doesn't help. It does match the PlayMissionGui now:

Before and After
image
image

Also fixed a small bug where the best time could show using the platinum color instead of the gold color on MBU on the PlayMissionGui.

Before After
image image
RandomityGuy commented 1 year ago

I took the colors from MBP 1.7.42 which is what I want to replicate in looks

thearst3rd commented 1 year ago

Gotcha, I figured :+1: You might still want the PlayMissionGui change, I just checked with MBP 1.7.42 and indeed the "Best Time" color looks like the right screenshot instead of the left screenshot in the last table. I can make that into another small PR.