search

RandyGaul / cute_framework

The *cutest* framework out there for creating 2D games in C++!
https://randygaul.github.io/cute_framework/#/
Other
534 stars 31 forks source link

Use bash on Windows #183

Closed pusewicz closed 2 months ago

pusewicz commented 2 months ago

This is so that the scripts can fail if commands return non-zero.

Cmd happily continues and never returns failures.

Ref https://github.com/actions/runner-images/issues/6668

RandyGaul commented 2 months ago

Bash isn't available on windows by default, so I'm not sure if this is a good solution. Are you sure it can't return failures? I've noticed the script runner here on github fail for windows a variety of times. Going to close this for now since I don't think we can swap the CI to bash here. Please re-open this if I'm mistaken.

pusewicz commented 2 months ago

Yeah, I need to open the PR to get the build started, so that was my only way to test this.

pusewicz commented 2 months ago

@RandyGaul

Bash isn't available on windows by default, so I'm not sure if this is a good solution

It is not available by default, but it is on the GitHub images. As you can see in the build failure, it's trying to cd into a directory and failing. The cd commands would need tweaking to resemble Unix paths I believe.