cute_math.h: GCC 12 ignores always_line and select any leading to multiple definition linker errors

[legends2k]

I've main.cpp and scene.cpp where cute_math.h is included. I define CUTE_MATH_IMPLEMENTATION in neither (since I don't need the larger functions). Compilation succeeds but linking fails with numerous warnings about attributes selectany and always_line ignored. Understandably linker errors ensure when linking. Sample errors:

Nila/build/cute_math.h:203:45: warning: ‘selectany’ attribute directive ignored [-Wattributes]
  203 | CUTE_MATH_SELECTANY cute_math_const_integer cute_math_mask_sign = { 0x80000000, 0x80000000, 0x80000000, 0x80000000 };
      |                                             ^~~~~~~~~~~~~~~~~~~

Nila/build/cute_math.h:645:36: warning: ‘always_inline’ function might not be inlinable [-Wattributes]
  645 | CUTE_MATH_INLINE q4 CUTE_MATH_CALL norm(q4 q)
      |                                    ^~~~

/usr/bin/c++ -g  CMakeFiles/nila.dir/src/main.cpp.o CMakeFiles/nila.dir/src/scene.cpp.o -o nila  libtigr.a  /usr/lib/libGLU.so  /usr/lib/libGLX.so  /usr/lib/libOpenGL.so  /usr/lib/libX11.so && :
/usr/bin/ld: CMakeFiles/nila.dir/src/scene.cpp.o:(.rodata+0x0): multiple definition of `cute::cute_math_mask_sign'; CMakeFiles/nila.dir/src/main.cpp.o:(.rodata+0x0): first defined here
/usr/bin/ld: CMakeFiles/nila.dir/src/scene.cpp.o:(.rodata+0x20): multiple definition of `cute::cute_math_mask_basis'; CMakeFiles/nila.dir/src/main.cpp.o:(.rodata+0x20): first defined here
/usr/bin/ld: CMakeFiles/nila.dir/src/scene.cpp.o:(.bss+0x0): multiple definition of `cute::identity_m3'; CMakeFiles/nila.dir/src/main.cpp.o:(.bss+0x0): first defined here

Relevant StackOverflow post: warning: always_inline function might not be inlinable [-Wattributes]

[legends2k]

Relevant issues #50, #17, #18.

[RandyGaul]

Any suggested solution?

[legends2k]

@RandyGaul For always_inline #18 already introduced the fix -- adding inline keyword along with the attribute. Looks like the fix was overwritten over time. Not sure of selectany though.

[RandyGaul]

Okay cool, could you make a PR for this?

[legends2k]

Okay cool, could you make a PR for this?

Done!

[RandyGaul]

Looks good!