RangeNetworks / OpenBTS-UMTS

3G UMTS Data Radio Access Network Node
GNU Affero General Public License v3.0
297 stars 196 forks source link

Configuration keys are inconsistent for min/max attenuation #5

Closed ttsou closed 8 years ago

ttsou commented 8 years ago

In the apps section of the code and in the example configuration file, UMTS.Radio.PowerManager is used for min/max attenuation values. The CLI uses GSM.Radio.PowerManager. This disparity may lead to crashing behavior when running OpenBTS-UMTS.

apps/OpenBTS-UMTS.example.sql

INSERT OR IGNORE INTO "CONFIG" VALUES('UMTS.Radio.PowerManager.MaxAttenDB','10',0,0,'Maximum transmitter attenuation level, in dB wrt full scale on the D/A output.  This sets the minimum power output level in the output power control loop.');
INSERT OR IGNORE INTO "CONFIG" VALUES('UMTS.Radio.PowerManager.MinAttenDB','0',0,0,'Minimum transmitter attenuation level, in dB wrt full scale on the D/A output.  This sets the maximum power output level in the output power control loop.');

apps/GetConfigurationKeys.cpp

        tmp = new ConfigurationKey("UMTS.Radio.PowerManager.MaxAttenDB","10",
                "dB",
                ConfigurationKey::CUSTOMERTUNE,
                ConfigurationKey::VALRANGE,
                "0:80",// educated guess
                false,
                "Maximum transmitter attenuation level, in dB wrt full scale on the D/A output.  "
                        "This sets the minimum power output level in the output power control loop."
        );
        map[tmp->getName()] = *tmp;
        delete tmp;

        tmp = new ConfigurationKey("UMTS.Radio.PowerManager.MinAttenDB","0",

CLI/CLI.cpp

    gConfig.set("GSM.Radio.PowerManager.MinAttenDB",argv[1]);
    gConfig.set("GSM.Radio.PowerManager.MaxAttenDB",argv[2]);