search

RangeNetworks / openbts

GSM+GPRS Radio Access Network Node
GNU Affero General Public License v3.0
869 stars 328 forks source link

Minor fixes for SMSCB #1

Open ervteng opened 10 years ago

ervteng commented 10 years ago

These fixes were necessary for me to get SMSCB working properly. Props to Chuck Bokath and Donald Kirker for the discussion on OpenBTS-Discuss that led to these changes.

Changed hardcoded language code in SMSCB.cpp to 0x01, which is English in the default GSM encoding, which fixes some display errors, especially on Android phones.

The fourth L2 CBCH frame in an SMSCB message now has the Last Block Bit properly set.

GSMTAP now properly reports SMSCB messages, and Wireshark shows the messages as expected.

iedemam commented 10 years ago

Hi Ervin,

Nice work! Glad you could turn this into a pull request. It's a great find to have fixed. We're still trying to get CLAs automated on GitHub but until then it's a manual process. I'll e-mail you the document.