search

RangeShifter / RScore

RangeShifter's core simulation code
GNU General Public License v3.0
0 stars 0 forks source link

RangeshiftR still builds with release-common version of RScode #4

Closed TheoPannetier closed 11 months ago

TheoPannetier commented 11 months ago

Before merging it to develop (and then master) , we need to make sure that we can still build RangeShiftR using the single-release version of RScore on branch release-common.

JetteReeg commented 11 months ago

I was able to compile the R package. I am still checking if this version reproduce the Rpackage tutorials

JetteReeg commented 11 months ago

There were some minor differences in tutorial 1, which I relate to stochasticity, but also some minor differences in tutorial 2, when actually a seed is set. So I would have expected no differences at all. I will dig a bit deeper into it and would compare the results presented in the tutorials with the current release version. But I guess we could nevertheless go on and continue? So the next step would be to merge release-common first into develop?

TheoPannetier commented 11 months ago

Great! I'll close this issue then and proceed with the merge :) Feel free to re-open this if you find something unsatisfactory in the tutorials output.