search

RangerMauve / dat-gateway

Visit https://github.com/garbados/dat-gateway/ instead
19 stars 4 forks source link

Improve handling of 500 errors #15

Closed brechtcs closed 6 years ago

brechtcs commented 6 years ago

This address the problem with stringifying server errors. Right now I've chosen to send err.message as a response to the client, but maybe it's better to return a more generic 'Server error' style message, to avoid unwanted information leaking out.

RangerMauve commented 6 years ago

I agree that having a generic error would be better. I don't think it'd be a good idea to leak stack traces to potential attackers. :x

RangerMauve commented 6 years ago

Would you be interested in being added as a collaborator on the repo? I'd still like to do code reviews (ideally for my code too), but you'd be able to do edits to the README and the such whenever you want.

brechtcs commented 6 years ago

Sure, always happy to help!

RangerMauve commented 6 years ago

Awesome! Thank you so much for your PRs! Great to see that other people are interested in this stuff.