Question: --expose-to-internet also required for P2P functionality

RangerMauve / dat-store

A CLI tool for backing up hyperdrive datasets

GNU Affero General Public License v3.0

59 stars 14 forks source link

Question: --expose-to-internet also required for P2P functionality #38

Closed jaller94 closed 4 years ago

jaller94 commented 4 years ago

Please clarify, if --expose-to-internet is also required for P2P sharing over the internet or only to allow remote configurations like dat-store add <hash> over the internet.

RangerMauve commented 4 years ago

Expose to internet is just for the HTTP server that dat-store uses for adding / removing archives. The P2P stuff uses the internet by default. Does that help disambiguate things a bit? 😁

Powersource commented 4 years ago

Yeah I misinterpreted this at first too and was almost about to expose my stuff to the internet which would have been bad. Maybe an update to the readme is needed.

RangerMauve commented 4 years ago

@Powersource Would you be down to take a shot at the README change? :P I'm not sure what the best wording would be.

Powersource commented 4 years ago

I think I would change the words "listen" and "expose" in this paragraph to "control". And add a sentence something like "This flag is not needed to share/download archives over the internet, and is only intended for advanced users"