search

RangerMauve / hyper-sdk

Make your own hyper apps!
https://www.youtube.com/watch?v=HyHk4aImd_I&list=PL7sG5SCUNyeYx8wnfMOUpsh7rM_g0w_cu&index=20
MIT License
290 stars 46 forks source link

fix: getSecretKey returns actual secret key #46

Closed nornagon closed 4 years ago

nornagon commented 4 years ago

Fixes #45.

Not sure when this broke, but given that the repo depends on a git branch of hyperdrive it seems likely that a hyperdrive change broke it.

Perhaps also consider switching to depend on a stable version of hyperdrive (maybe a commit or tag rather than a branch name?)

RangerMauve commented 4 years ago

This looks great, thank you!

By the way, there's a new branch in the works for Dat2 support #36 and the promise based interface is going to be replaced in favor of having the ability to omit callbacks to get promises back using the hyperdrive-promise library. This'll unify the API into one thing rather than a separate promise and callback one.

Not sure what the alternative for getSecretKey is gonna look like in this new API. Might just be archive.secretKey.

This change is going to be breaking with the new Hyperdrive API in Beaker for now so you might be better off staying with the current release until all that stuff is stabilized.

nornagon commented 4 years ago

Sounds great, unfortunately I wanted to experiment with in-browser usage of Dat, which it seems like Dat2 doesn't yet support.

RangerMauve commented 4 years ago

Yeah, another reason to stick to the 1.x version of the SDK for now 😁

I've released this fix in version 1.0.3 BTW!

Thanks again for the PR