RangerMauve / hypercore-fetch

Implementation of Fetch that uses the Hyper SDK for loading p2p content
MIT License
36 stars 12 forks source link

Last-Modified header missing #48

Closed josephmturner closed 1 year ago

josephmturner commented 1 year ago

Files created with PUT requests should have a Last-Modified header, but they currently do not.

RangerMauve commented 1 year ago

Just to clarify, the Last-Modified header should be getting set on the response to a GET on the file and it currently isn't right?

RangerMauve commented 1 year ago

Found the bug. This also affected the HEAD requests.

Maybe TypeScript types would have caught this issue early on. :P

RangerMauve commented 1 year ago

Fixed in hypercore-fetch@9.0.6 and out in hyper-gateway@3.0.3

josephmturner commented 1 year ago

Thanks! I can confirm this is no longer an issue.