search

RangerMauve / js-ipfs-fetch

Use the same `fetch()` API browsers provide for HTTP, but for IPFS
https://youtu.be/kI9Issf3MNc?t=1606
MIT License
64 stars 7 forks source link

fix: base32 for ipfs:// urls and cidv1 everywhere #5

Closed olizilla closed 3 years ago

olizilla commented 3 years ago

base36 is the right thing to use to respect the max authority length for ipns:// scheme urls. The assumption is folks should use base32 for CIDs in ipfs:// scheme urls, and it's the default output for cidv1.

The new ipfs-core modules has the same api as the ipfs module but doesn't include the cli and http-server code with it.

At time of writing the tests pass apart from the last one, which hangs. I think it's due to an unrelated bug https://github.com/ipfs/js-ipfs/issues/3692

License: MIT Signed-off-by: Oli Evans oli@tableflip.io

olizilla commented 3 years ago

I'll chase down https://github.com/ipfs/js-ipfs/issues/3692 when i get time and see if I can get that unrelated test hang fixed.

RangerMauve commented 3 years ago

Thanks for the clarifications, @lidel!

RangerMauve commented 3 years ago

Published in 2.0.0 since this changes how URLs work. Thanks again for the PR and thanks @lidel for the clarification.

olizilla commented 3 years ago

🎉 what a nice thread to wake up to! Thanks @lidel and lovely work on this module @RangerMauve !