Finished IPFS support, added improvements

RangerMauve / webrun

Run Web-first ESM modules outside of the browser

https://webrun-presentation.hashbase.io/

MIT License

77 stars 8 forks source link

Finished IPFS support, added improvements #19

Closed RangerMauve closed 5 years ago

RangerMauve commented 5 years ago

Added support for loading ipfs:// and ipns:// URLs
Added ipfs global which is an instance of js-ipfs
Fixes #18 by using require.resolve with process.cwd()
Added WhatWG Streams to globals (ReadableStream, WritableStream, etc)
Closes #12 by mentioning webrunify in the README
Fixed an issue with dynamic import() support
Fixes #16 with a prepublish script which changes the windows file endings to unix file endings.

RangerMauve commented 5 years ago

@gozala what do you think of this? :D

brechtcs commented 5 years ago

Not essential to the PR, but I did notice that the commits on this branch aren't linked to your Github profile as they should. I guess you made them on a different device with a different email in gitconfig.

Coincidentally, I just fixed this myself somewhere else today. So in case you need it, this is the script I used:

git filter-branch -f --commit-filter '
if [ "$GIT_AUTHOR_NAME" = "Brecht Savelkoul" ];
then
    GIT_AUTHOR_EMAIL="brecht.savelkoul@gmail.com";
    GIT_COMMITTER_EMAIL="brecht.savelkoul@gmail.com";
    git commit-tree "$@";
else
    git commit-tree "$@";
fi' HEAD

git push -f

RangerMauve commented 5 years ago

I was going to do a squash merge through GH so I'd still be on the commits.

It's weird that IPFS doesn't have a hashbase equivalent. ¯_(ツ)_/¯

@brechtcs Would you mind doing another quick review of the IPFS loading code?

RangerMauve commented 5 years ago

Thank you for the review!