search

RangerMauve / webrun

Run Web-first ESM modules outside of the browser
https://webrun-presentation.hashbase.io/
MIT License
76 stars 4 forks source link

Add "engines" field to package.json #31

Closed basham closed 3 weeks ago

basham commented 4 years ago

This pull request is to supplement this issue: https://github.com/RangerMauve/webrun/issues/30

This has not been tested. I tried to get WebRun working locally from my fork last week, and I was running into issues. So, I don't quite know how to move forward on this. Additionally, the tests as I found them have not been updated alongside the project, so they're broken and out of date. I don't have the time right now to do further explorations on this. So, just consider with pull request as a way to illustrate what I suspect you could do, rather than what you should do.

basham commented 4 years ago

I placed the engines field last in package.json, because engines was the bottommost field that this package uses, within the context of the docs.

RangerMauve commented 4 years ago

Sweet. Thank you for investigating! I'll need to put this on the backburner for a bit since I don't have time for rigorous testing at the moment. :purple_heart: