search

Rangi42 / polishedcrystal

An upgrade to Pokémon Crystal. Brings features and content up to date, and adds some original content.
https://hax.iimarckus.org/topic/6874/
1.03k stars 197 forks source link

Objects may be retained through map connections #959

Closed vulcandth closed 1 month ago

vulcandth commented 3 months ago

If an object's xy coordinates relative to the player's matches a new mapobject's xy coordinates relative to the player, and their sprite matches, then than object will be retained/reassociated with the new mapobject.

This resolves the issue of object reshuffling when crossing map connections; particularly the cut tree flicker on route32.

vulcandth commented 2 months ago

Either merge this before weather.. or after weather.. Do not merge at the same time... I'll need to verify that the changes they both do to the object system do not conflict... so we should delay one of these PR's merge after the other's merge so I can verify there are not conflicts.

vulcandth commented 2 months ago

Resolved merge conflicts; drafting this until I feel comfortable there are no in game conflicts with weather.