Rangi42 / polishedcrystal

An upgrade to Pokémon Crystal. Brings features and content up to date, and adds some original content.
https://hax.iimarckus.org/topic/6874/
1.05k stars 202 forks source link

Fix Stats screen at max volume #970

Closed vulcandth closed 1 month ago

vulcandth commented 4 months ago

I opened this as a PR mainly because I don't fully understand why the this fixes the problem.. but it does fix it.

This was fixed in CSE.. see the issue there:
reference fellowship-of-the-roms/CrystalShireEngine#27

Furthermore, this is probably also related to Darsh' comment here: https://github.com/Rangi42/polishedcrystal/issues/857#issuecomment-1826199307

>I do think there's something wrong with the sound engine. A Pokemon's cry in the status screen isn't always going to have consistent volume (Voltorb is a good example of this). Not clear what's causing the issue.