search

Rangi42 / redstarbluestar

An upgrade to Pokémon Red/Blue. Ports graphics and features from the Space World 1997 Gold/Silver prototype.
https://hax.iimarckus.org/topic/7470/
108 stars 23 forks source link

NVE sound playing on neutral damage #2

Closed Nalydris closed 4 years ago

Nalydris commented 4 years ago

In line 3031 of engine/battle/animations.asm change jr nc, .playSound to jr z, .playSound to fix the issue

Rangi42 commented 4 years ago

Thanks! I see Red++ 3 also fixed this bug, as well as swapping the ld d, a and cp %00000010, apparently to fix super-effective sound checks.