RankWeis / uppercut

FREE Karate plugin for IntelliJ with additional features
Apache License 2.0
6 stars 0 forks source link

about some keywords #38

Closed calvario-31 closed 1 week ago

calvario-31 commented 1 week ago

I would say thanks again for this plugin. Have a couple of questions regarding the keywords and their colors

first question

I want to highlight if there is some kind of rule for the color of the keywords. I have this small example Screenshot 2024-11-05 at 1 48 43 PM Screenshot 2024-11-05 at 1 49 50 PM

for example the keyword status on uppercut is not being highlighted even if it is a reserved keyword on karate DSL I would expect to be also orange

But maybe you have some other thoughts about this? that's why im asking if there is some kind of rule your are following

second question have you considered changing the give when then color from dark green to another? now is kinda hard to read and have the same color of the comments (I also have the same issue with official karate plugin that is grey lol)

RankWeis commented 1 week ago

have you considered changing the give when then color from dark green to another?

Yes, 100% I have, I just have no eye for this kind of thing and this is the default color style from cucumber plugin that I rely heavily on to do a lot of the work.

And as for status, easily fixed - https://github.com/RankWeis/uppercut/pull/39 I should really find a list of all keywords but I don't think there's a compiled one out there, so I kind of fly by what we use in our team, and we had never used status directly.

calvario-31 commented 1 week ago

thanks for the status keyword, if I find more i will ping you for the color yes i think is a hard thing to standarize. If you know a way how i can change the colors for the file I can help you to find some color that are easier to see so you can check it

calvario-31 commented 1 week ago

Update: I found karate color scheme, seems Given When Then share the same settings as a comment haha that's why they have the same color

calvario-31 commented 1 week ago

image i believe this color is easier to see, i would only add those color to given/when/then and not the comments since is too bright Sadly I dont know a way to split between comment and given when then settings

image

if you like this is the hex value: 6DA5FF

image

RankWeis commented 1 week ago

Rather than changing the default color for everyone who may have gotten used to this by now, I went ahead and separated out those two categories and now you can modify to your preference!

https://github.com/RankWeis/uppercut/pull/40

calvario-31 commented 1 week ago

thanks!