Rantanen / intercom

Object based cross-language FFI for Rust
MIT License
63 stars 7 forks source link

Import syn types explicitly #110

Closed Fluxie closed 5 years ago

Fluxie commented 5 years ago

Syn exports its own Result type which conflicts with the standard Result type leading to compilation errors.

codecov-io commented 5 years ago

Codecov Report

Merging #110 into master will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   81.37%   81.35%   -0.02%     
==========================================
  Files          57       57              
  Lines        5068     5068              
==========================================
- Hits         4124     4123       -1     
- Misses        944      945       +1
Impacted Files Coverage Δ
intercom-common/src/attributes/com_interface.rs 96.82% <ø> (ø) :arrow_up:
intercom-common/src/attributes/com_impl.rs 100% <ø> (ø) :arrow_up:
intercom-common/src/ast_converters.rs 38.27% <ø> (ø) :arrow_up:
intercom-common/src/returnhandlers.rs 85.71% <ø> (ø) :arrow_up:
intercom-common/src/attributes/com_class.rs 100% <ø> (ø) :arrow_up:
intercom-common/src/methodinfo.rs 90.77% <100%> (ø) :arrow_up:
intercom-common/src/lib.rs 0% <0%> (-100%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5bdfc47...9c4b8ab. Read the comment docs.

Rantanen commented 5 years ago

Oh, this explains why it was working on my system. Cargo.lock must have prevented Syn updates. Thanks!