Fluxie commented 5 years ago

The direction member in the TypeContext struct was very difficult to work with when I tried to implement structs which are essentially nested types. The type handles of the individual fields of the structs should not be aware of the direction of struct. The direction is now given as a parameter during code generation,for the type handler.

codecov-io commented 5 years ago

Codecov Report

Merging #111 into master will decrease coverage by <.01%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
- Coverage   81.35%   81.34%   -0.01%     
==========================================
  Files          57       57              
  Lines        5068     5067       -1     
==========================================
- Hits         4123     4122       -1     
  Misses        945      945

Impacted Files	Coverage Δ
intercom-common/src/attributes/com_interface.rs	`96.82% <100%> (ø)`	:arrow_up:
intercom-common/src/tyhandlers.rs	`83.58% <100%> (ø)`	:arrow_up:
intercom-common/src/methodinfo.rs	`90.77% <100%> (ø)`	:arrow_up:
intercom-common/src/generators/cpp.rs	`81.07% <100%> (ø)`	:arrow_up:
intercom-common/src/attributes/com_impl.rs	`100% <100%> (ø)`	:arrow_up:
intercom-common/src/generators/idl.rs	`82.37% <100%> (ø)`	:arrow_up:
intercom-common/src/returnhandlers.rs	`85.59% <100%> (-0.13%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ef7e10e...7237b52. Read the comment docs.

Rantanen commented 5 years ago

Looks good; Thanks!

Rantanen / intercom

Removed direction member from TypeContext #111

Codecov Report