Rantanen / intercom

Object based cross-language FFI for Rust
MIT License
63 stars 7 forks source link

Split C++ tests into raw and wrapper tests #54

Closed Rantanen closed 6 years ago

Rantanen commented 6 years ago

I was looking into enabling exceptions and interface_wrappers tests for Windows and I'm struggling to find a clear way to do this - being a bit afraid of the #import test_lib.dll and #include "test_lib.h" conflicting with each other.

While it would be possible to have all of these tests under the same project/solution/whatever you want to call it, I would prefer the clarity of having every test in cpp-raw come with the same prelude and having the same support classes available to it - instead of opening a random.cpp file and then having to scan includes to see whether that specific file has stuff like CreateInstance available to it or whether it should use ClassFactory::create.

I'm proposing the following:

cpp-raw

cpp-wrapper

@Fluxie Opinions?

Fluxie commented 6 years ago

This was implemented in #63.

Rantanen commented 6 years ago

Great! I didn't even remember we had an issue for this. ^^