search

Rantanen / intercom

Object based cross-language FFI for Rust
MIT License
63 stars 7 forks source link

Basic support for BSTR <-> Rust conversions on Linux #60

Closed Fluxie closed 6 years ago

Fluxie commented 6 years ago

Conversions currently supported: Bstr -> &str Bstr -> String String -> Bstr

Related tests cases are not enabled on Windows because support for UTF-8 -> BSTR and BSTR -> UTF-8 conversions have not been implemented at this point.

codecov-io commented 6 years ago

Codecov Report

Merging #60 into master will increase coverage by 1.38%. The diff coverage is 86.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   76.31%   77.69%   +1.38%     
==========================================
  Files          49       55       +6     
  Lines        3120     3300     +180     
==========================================
+ Hits         2381     2564     +183     
+ Misses        739      736       -3
Impacted Files Coverage Δ
intercom-common/src/attributes/com_class.rs 100% <ø> (ø) :arrow_up:
intercom-cpp/src/no_such_interface.h 100% <ø> (+47.05%) :arrow_up:
intercom-cpp/src/posix/dlwrapper.h 83.33% <ø> (ø) :arrow_up:
intercom-attributes/src/lib.rs 56% <ø> (ø) :arrow_up:
intercom-common/src/generators/idl.rs 82.11% <100%> (ø) :arrow_up:
intercom-cpp/src/detail/char_buffer.h 100% <100%> (ø)
intercom-cpp/src/raw_interface.h 96.87% <100%> (ø) :arrow_up:
intercom-cpp/src/activator.h 83.33% <100%> (ø) :arrow_up:
intercom-cpp/src/posix/detail/memory.h 100% <100%> (ø)
intercom-cpp/src/guiddef.h 100% <100%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66632ae...7a90986. Read the comment docs.

Rantanen commented 6 years ago

Finally had time to go through these changes properly. Looks really great! Thanks!