Closed Fluxie closed 6 years ago
Sorry for the conflicts. I normalized all the indent to spaces. Most of the Rust code was already using spaces so that felt like the way to go; C++ code unfortunately wasn't!
There should be no other changes to those files - so feel free to resolve those changes by overwriting them and then doing a format pass yourself. There is an .editorconfig
file in the repository now so any supporting editor should pick the settings up automatically.
Visual Studio 2017 should have built-in support. There is a plugin for VSCode.
Merging #64 into master will decrease coverage by
0.33%
. The diff coverage is11.11%
.
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 76.47% 76.13% -0.34%
==========================================
Files 52 52
Lines 3213 3231 +18
==========================================
+ Hits 2457 2460 +3
- Misses 756 771 +15
Impacted Files | Coverage Δ | |
---|---|---|
intercom-cpp/src/guiddef.h | 0% <ø> (ø) |
:arrow_up: |
intercom-cpp/src/activator.h | 86.66% <ø> (ø) |
:arrow_up: |
intercom-cpp/src/detail/utility.h | 16.66% <ø> (ø) |
:arrow_up: |
intercom-common/src/attributes/com_library.rs | 0% <0%> (ø) |
:arrow_up: |
intercom-cli/src/main.rs | 2% <0%> (-0.05%) |
:arrow_down: |
intercom-common/src/generators/cpp.rs | 80.51% <100%> (-0.09%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4096049...5eff689. Read the comment docs.
Looks good!
Those errors looked weird. Retried the CIs to see whether that fixes the issues.