Closed Fluxie closed 6 years ago
Merging #67 into master will decrease coverage by
1.95%
. The diff coverage is55.24%
.
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 76.47% 74.51% -1.96%
==========================================
Files 52 56 +4
Lines 3213 3433 +220
==========================================
+ Hits 2457 2558 +101
- Misses 756 875 +119
Impacted Files | Coverage Δ | |
---|---|---|
intercom-attributes/src/lib.rs | 50% <ø> (-6%) |
:arrow_down: |
intercom-cpp/src/raw_interface.h | 100% <ø> (ø) |
|
intercom-common/src/foreign_ty.rs | 100% <ø> (ø) |
:arrow_up: |
intercom/src/lib.rs | 25% <ø> (-12.5%) |
:arrow_down: |
intercom-build/src/lib.rs | 0% <ø> (-25%) |
:arrow_down: |
intercom-common/src/idents.rs | 100% <ø> (ø) |
:arrow_up: |
intercom-common/src/builtin_model.rs | 91.3% <ø> (ø) |
:arrow_up: |
intercom-cli/src/main.rs | 0% <0%> (-2.05%) |
:arrow_down: |
intercom-common/src/attributes/com_library.rs | 0% <0%> (ø) |
:arrow_up: |
intercom-fmt/src/main.rs | 0% <0%> (ø) |
|
... and 35 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4096049...367e4dc. Read the comment docs.
Glanced through the code quickly. DIdn't pay too much attention in the actual C++ code. I'll trust the tests for that. Thanks!
The name of the library is no longer required to create COM classes on POSIX. The libraries are discovered automatically at runtime. The interface is now inline with Windows. However, unlike on Windows, on POSIX the libraries need to be linked to the application for the discovery to work.