Closed Rantanen closed 5 years ago
Fixes #78 once merged.
Fixes #81 once merged.
Merging #80 into master will increase coverage by
0.11%
. The diff coverage is79.02%
.
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 73.87% 73.98% +0.11%
==========================================
Files 56 55 -1
Lines 3785 3856 +71
==========================================
+ Hits 2796 2853 +57
- Misses 989 1003 +14
Impacted Files | Coverage Δ | |
---|---|---|
intercom-common/src/model/comcrate.rs | 87.96% <ø> (ø) |
:arrow_up: |
intercom-common/src/idents.rs | 62.96% <ø> (ø) |
:arrow_up: |
intercom/src/error.rs | 13.67% <0%> (-0.12%) |
:arrow_down: |
intercom-common/src/generators/cpp.rs | 80.92% <100%> (ø) |
:arrow_up: |
intercom-common/src/attributes/com_impl.rs | 100% <100%> (ø) |
:arrow_up: |
intercom-common/src/generators/idl.rs | 82.24% <100%> (ø) |
:arrow_up: |
intercom-common/src/type_parser.rs | 76.35% <100%> (ø) |
:arrow_up: |
intercom-common/src/attributes/com_class.rs | 100% <100%> (ø) |
:arrow_up: |
intercom/src/lib.rs | 45.45% <100%> (+20.45%) |
:arrow_up: |
intercom/src/alloc.rs | 65.85% <100%> (ø) |
:arrow_up: |
... and 15 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d4c84ea...71c46a8. Read the comment docs.
Previously the
Deref
was implemented through the attributes. Now that we have it in the intercom crate itself we don't needfundamental
feature anymore.To drop the requirement for
fundamental
someFrom
, etc. implementations were also removed for now. These should be implemented within the intercom crate in a similar manner to theDeref
in the future.They weren't used in the tests either so I was too tired to figure out what the big benefit with them was. I believe they did some interface querying, etc. but we can live without that for now.These were handling the
ComStruct
intoComItf
return values values. They have now been re-implemented by implementing theHasInterface<T>
marker trait on the underlying user structs instead of having toimpl
them on ComStruct/ComItf in the user crate.This caused #81, which has now been resolved.