Closed Rantanen closed 5 years ago
Merging #85 into master will increase coverage by
0.22%
. The diff coverage is68.84%
.
@@ Coverage Diff @@
## master #85 +/- ##
==========================================
+ Coverage 73.82% 74.05% +0.22%
==========================================
Files 55 55
Lines 3889 4012 +123
==========================================
+ Hits 2871 2971 +100
- Misses 1018 1041 +23
Impacted Files | Coverage Δ | |
---|---|---|
intercom/src/lib.rs | 45.45% <ø> (ø) |
:arrow_up: |
intercom-common/src/generators/cpp.rs | 80.98% <100%> (+0.06%) |
:arrow_up: |
intercom-common/src/generators/idl.rs | 82.31% <100%> (+0.06%) |
:arrow_up: |
intercom/src/strings.rs | 68.07% <58.76%> (+0.87%) |
:arrow_up: |
intercom-common/src/returnhandlers.rs | 85.71% <75%> (-0.5%) |
:arrow_down: |
intercom-common/src/tyhandlers.rs | 80.36% <93.1%> (+3.77%) |
:arrow_up: |
intercom/src/alloc.rs | 80.48% <0%> (+14.63%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c4dbf1e...069d1c5. Read the comment docs.
The raw type system uses raw C-strings (null terminated strings with 1-byte characters). This isn't necessarily the final form and is up for debate, but I wanted some sort of support for raw type system strings so we can test the type system infrastructure works.
On the other hand I do feel there is some value in supporting C-strings as well. I wonder if it would make sense to support 3 type systems instead of the current two: